Skip to content

repl: Assignment of _ allowed with warning #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lance wants to merge 6 commits into from
Closed

repl: Assignment of _ allowed with warning #5535

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cc2713
repl: Assignment of _ allowed with warning
lance Mar 2, 2016
1dd5e2a
repl: Reset underscore assignment on .clear
lance Mar 3, 2016
ca199e2
doc: Document `_` behavior in REPL.
lance Mar 8, 2016
4062e62
repl: Adjust docs for `_` usage, and tighten test.
lance Mar 11, 2016
428cef6
repl: Test `_` behavior in `REPL_MODE_MAGIC` mode.
lance Mar 11, 2016
1471d13
repl: Change warning text to a complete sentence.
lance Mar 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
repl: Test _ behavior in REPL_MODE_MAGIC mode. 
Add a test based on feedback from @cjihrig. Ensures that when used
in 'magic' mode, the behavior of `_` assignment is consistent with
other modes and user expectations.
  • Loading branch information
@lance
lance committed Mar 15, 2016
commit 428cef65eeafe61f23c32997ceaaec5d4ae91060
34 changes: 34 additions & 0 deletions test/parallel/test-repl-underscore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const stream = require('stream');
testSloppyMode();
testStrictMode();
testResetContext();
testMagicMode();

function testSloppyMode() {
const r = initRepl(repl.REPL_MODE_SLOPPY);
Expand Down Expand Up @@ -75,6 +76,39 @@ function testStrictMode() {
]);
}

function testMagicMode() {
const r = initRepl(repl.REPL_MODE_MAGIC);

r.write(`_; // initial value undefined
x = 10; //
_; // last eval - 10
let _ = 20; // undefined
_; // 20 from user input
_ = 30; // make sure we can set it twice and no prompt
_; // 30 from user input
var y = 40; // make sure eval doesn't change _
_; // remains 30 from user input
function f() { let _ = 50; return _; } // undefined
f(); // 50
_; // remains 30 from user input
`);

assertOutput(r.output, [
'undefined',
'10',
'10',
'undefined',
'20',
'30',
'30',
'undefined',
'30',
'undefined',
'50',
'30'
]);
}

function testResetContext() {
const r = initRepl(repl.REPL_MODE_SLOPPY);

Expand Down