Skip to content

test: add a place for reproducing known bugs #5528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjihrig wants to merge 2 commits into from
Closed

test: add a place for reproducing known bugs #5528

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ba2eb
tools: support testing known issues
cjihrig Mar 2, 2016
48e7009
test: bug repro for vm function redefinition
cjihrig Mar 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: bug repro for vm function redefinition 
This commit adds a failing test case for the vm module.
Currently, if runInContext() defines a function, and a later call
to runInContext() redefines the same function, the original
function is not overwritten.

Refs: #548
  • Loading branch information
@cjihrig
cjihrig committed Mar 3, 2016
commit 48e70092aa94c178ae0678292dbe5d5df18dcf08
11 changes: 11 additions & 0 deletions test/known_issues/test-vm-function-redefinition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'use strict';
// Refs: https://github.com/nodejs/node/issues/548
require('../common');
const assert = require('assert');
const vm = require('vm');
const context = vm.createContext();

vm.runInContext('function test() { return 0; }', context);
vm.runInContext('function test() { return 1; }', context);
const result = vm.runInContext('test()', context);
assert.strictEqual(result, 1);