Skip to content

lib: remove lib/internal/idna.js #55050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Sep 23, 2024
Merged

lib: remove lib/internal/idna.js #55050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: remove lib/internal/idna.js
  • Loading branch information
@anonrig
anonrig committed Sep 21, 2024
commit 22d963caa8e0cc5544a79c6a22bf2f67866375a2
4 changes: 0 additions & 4 deletions lib/internal/idna.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const {
decodeURIComponent,
} = primordials;

const { toASCII } = require('internal/idna');
const { toASCII } = internalBinding('encoding_binding');
const { encodeStr, hexTable } = require('internal/querystring');
const querystring = require('querystring');

Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-bootstrap-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ expected.atRunTime = new Set([

if (common.isMainThread) {
[
'NativeModule internal/idna',
'NativeModule url',
].forEach(expected.beforePreExec.add.bind(expected.beforePreExec));
} else { // Worker.
Expand Down