Skip to content

test: add asserts to validate test assumptions #54997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 2 commits into from
Closed

test: add asserts to validate test assumptions #54997

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ad09ca
test: add asserts to validate test assumptions
mhdawson Sep 18, 2024
38bb9d6
Update test/parallel/test-tls-cert-regression.js
mhdawson Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add asserts to validate test assumptions 
Refs: #54968
Refs: #53382

Add additional asserts as suggestd by Richard in:
#54968

Signed-off-by: Michael Dawson <midawson@redhat.com>
  • Loading branch information
@mhdawson
mhdawson committed Sep 18, 2024
commit 7ad09cac48ba1bdba7f448fe8129f58b42e036d7
3 changes: 3 additions & 0 deletions test/parallel/test-tls-cert-regression.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
const assert = require('assert');

if (!common.hasCrypto)
common.skip('missing crypto');
Expand All @@ -43,6 +44,8 @@ while (cert[cert.length - 1 - i] === 0x0a) i++;
if (i !== 0) cert = cert.slice(0, cert.length - i);

function test(cert, key, cb) {
assert.notStrictEqual(cert[cert.length - 1], 0x0a);
assert.notStrictEqual(key[key.length - 1], 0x0a);
Comment thread
mhdawson marked this conversation as resolved.
Outdated
const server = tls.createServer({
cert,
key
Expand Down