Skip to content

lib: implement interface converter and use it for AbortSignal validation #54965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jazelly wants to merge 2 commits into from
Closed

lib: implement interface converter and use it for AbortSignal validation #54965

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce65d65
lib: implement interface converter in webidl
jazelly Sep 17, 2024
82da5e9
lib: validate signals with interface converter
jazelly Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib: implement interface converter in webidl
  • Loading branch information
@jazelly
jazelly committed Sep 19, 2024
commit ce65d653e50ad71a9398c713e23babeedee9bb3b
18 changes: 17 additions & 1 deletion lib/internal/webidl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const {
NumberMAX_SAFE_INTEGER,
NumberMIN_SAFE_INTEGER,
ObjectAssign,
ObjectPrototypeIsPrototypeOf,
SafeSet,
String,
SymbolIterator,
Expand All @@ -20,6 +21,7 @@ const {

const {
codes: {
ERR_INVALID_ARG_TYPE,
ERR_INVALID_ARG_VALUE,
},
} = require('internal/errors');
Expand Down Expand Up @@ -275,20 +277,34 @@ function createSequenceConverter(converter) {
const val = converter(res.value, {
__proto__: null,
...opts,
context: `${opts.context}, index ${array.length}`,
Comment thread
jazelly marked this conversation as resolved.
context: `${opts.context}[${array.length}]`,
});
ArrayPrototypePush(array, val);
};
return array;
};
}

// https://webidl.spec.whatwg.org/#js-interface
function createInterfaceConverter(name, I) {
return (V, opts = kEmptyObject) => {
Comment thread
KhafraDev marked this conversation as resolved.
// 1. If V implements I, then return the IDL interface type value that
Comment thread
jazelly marked this conversation as resolved.
// represents a reference to that platform object.
if (ObjectPrototypeIsPrototypeOf(I, V)) return V;
// 2. Throw a TypeError.
throw new ERR_INVALID_ARG_TYPE(
typeof opts.context === 'string' ? opts.context : 'value', name, V,
);
};
}


module.exports = {
type,
converters,
convertToInt,
createEnumConverter,
createInterfaceConverter,
createSequenceConverter,
evenRound,
makeException,
Expand Down