Skip to content

src: improve utf8 string generation performance #54873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Sep 17, 2024
Merged

src: improve utf8 string generation performance #54873

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ea7fc4
src: improve utf8 string generation performance
anonrig Sep 10, 2024
435fa04
Update util.cc
anonrig Sep 10, 2024
cb36b86
Update src/util.cc
anonrig Sep 12, 2024
4b28cf1
Update src/util.cc
anonrig Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/util.cc 
Co-authored-by: Robert Nagy <ronagy@icloud.com>
  • Loading branch information
@anonrig @ronag
anonrig and ronag authored Sep 12, 2024
commit cb36b86d92eb5fde2f4a1c07d5db8d8957c46a4e
2 changes: 1 addition & 1 deletion src/util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ static void MakeUtf8String(Isolate* isolate,
if (value_view.is_one_byte()) {
Comment thread
anonrig marked this conversation as resolved.
auto const_char = reinterpret_cast<const char*>(value_view.data8());
auto expected_length =
target->capacity() > (static_cast<size_t>(value_length) * 2 + 1)
target->capacity() < (static_cast<size_t>(value_length) * 2 + 1)
? simdutf::utf8_length_from_latin1(const_char, value_length)
: value_length * 2;

Expand Down