Skip to content

repl: avoid interpreting 'npm' as a command when errors are recoverable #54848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Sep 15, 2024
+24 −1
Merged

repl: avoid interpreting 'npm' as a command when errors are recoverable #54848

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b1e9ca
repl: avoid interpreting 'npm' as a command when errors are recoverable
islandryu Sep 8, 2024
8892202
repl: Add test for recoverable errors
islandryu Sep 9, 2024
c7203dd
repl: remove valid js test including npm
islandryu Sep 9, 2024
2bdc4a4
repl: fix lint
islandryu Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
repl: fix lint
  • Loading branch information
@islandryu
islandryu committed Sep 11, 2024
commit 2bdc4a4fd942d5d304c18c322f325ab9a60dc6e9
2 changes: 1 addition & 1 deletion test/parallel/test-repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const possibleTokensAfterIdentifierWithLineBreak = [
'= \n1', '+= \n1', '-= \n1', '*= \n1', '/= \n1', '%= \n1',
': \n',
'? \n1: 1',
]
];

const errorTests = [
// Uncaught error throws and prints out
Expand Down