Skip to content

test_runner: add cwd option to run #54705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 20 commits into from
Oct 3, 2024
Merged

test_runner: add cwd option to run #54705

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
91858b0
test_runner: add cwd option to run
pmarchini Oct 1, 2024
85e7dbb
test_runner: add --experimental-test-cwd option to test runner
pmarchini Oct 1, 2024
e35b227
Update doc/api/cli.md
pmarchini Oct 1, 2024
7d34799
test_runner: refactor cwd handling in test runner
pmarchini Oct 1, 2024
18138e9
test: add isolation test cases to test runner run watch
pmarchini Oct 1, 2024
8fac041
test: add test cases
pmarchini Oct 1, 2024
0e9d10d
test_runner: add validation for run cwd option
pmarchini Oct 1, 2024
e6e8329
test_runner: remove cwd path validation
pmarchini Oct 1, 2024
69acadf
test: update test case
pmarchini Oct 1, 2024
b600dda
test_runner: revert new line
pmarchini Oct 1, 2024
9120999
test_runner: remove cwd fallback
pmarchini Oct 1, 2024
37014cc
test_runner: remove additional param
pmarchini Oct 1, 2024
565a938
test_runner: fix unix failures
pmarchini Oct 1, 2024
9aea826
test: lint
pmarchini Oct 1, 2024
c9288af
test: remove setInterval
pmarchini Oct 1, 2024
71ea33d
test: apply suggestions
pmarchini Oct 1, 2024
e995bec
test_runner: avoid spread operation
pmarchini Oct 1, 2024
c6d0cec
test: refactor watch cwd tests
pmarchini Oct 1, 2024
e0b7a48
test: divide test cases
pmarchini Oct 2, 2024
a162f2d
test: remove event listeners before abort
pmarchini Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: remove cwd path validation
  • Loading branch information
@pmarchini
pmarchini committed Oct 1, 2024
commit e6e83292d673688ac13c095b8c9c9d87c6648674
7 changes: 0 additions & 7 deletions lib/internal/test_runner/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ const {
} = require('internal/test_runner/utils');
const { Glob } = require('internal/fs/glob');
const { once } = require('events');
const { existsSync, lstatSync } = require('fs');
const {
triggerUncaughtException,
exitCodes: { kGenericUserError },
Expand Down Expand Up @@ -591,12 +590,6 @@ function run(options = kEmptyObject) {

validateString(cwd, 'options.cwd');

if (existsSync(cwd) === false) {
throw new ERR_INVALID_ARG_VALUE('options.cwd', cwd, 'expects an existing directory');
} else if (!lstatSync(cwd).isDirectory()) {
throw new ERR_INVALID_ARG_VALUE('options.cwd', cwd, 'expects a directory, a file was provided');
}

if (globPatterns?.length > 0 && files?.length > 0) {
throw new ERR_INVALID_ARG_VALUE(
'options.globPatterns', globPatterns, 'is not supported when specifying \'options.files\'',
Expand Down
58 changes: 48 additions & 10 deletions test/parallel/test-runner-run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,22 +547,60 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
for await (const _ of stream);
});

it('should throw if an invalid cwd is provided', async () => {
assert.throws(() => run({
it('should handle a non-existent directory being provided as cwd', async () => {
const diagnostics = [];
const stream = run({
cwd: fixtures.path('test-runner', 'cwd', 'non-existing')
}), {
code: 'ERR_INVALID_ARG_VALUE',
message: /expects an existing directory/
});
stream.on('test:fail', common.mustNotCall());
stream.on('test:pass', common.mustNotCall());
stream.on('test:stderr', common.mustNotCall());
stream.on('test:diagnostic', ({ message }) => {
diagnostics.push(message);
});

// eslint-disable-next-line no-unused-vars
for await (const _ of stream);
for (const entry of [
'tests 0',
'suites 0',
'pass 0',
'fail 0',
'cancelled 0',
'skipped 0',
'todo 0',
]
) {
assert.strictEqual(diagnostics.includes(entry), true);
}
});

it('should throw if a file is provided as cwd', async () => {
assert.throws(() => run({
it('should handle a non-existent file being provided as cwd', async () => {
const diagnostics = [];
const stream = run({
cwd: fixtures.path('test-runner', 'default-behavior', 'test', 'random.cjs')
}), {
code: 'ERR_INVALID_ARG_VALUE',
message: /expects a directory, a file was provided/
});
stream.on('test:fail', common.mustNotCall());
stream.on('test:pass', common.mustNotCall());
stream.on('test:stderr', common.mustNotCall());
stream.on('test:diagnostic', ({ message }) => {
diagnostics.push(message);
});

// eslint-disable-next-line no-unused-vars
for await (const _ of stream);
for (const entry of [
'tests 0',
'suites 0',
'pass 0',
'fail 0',
'cancelled 0',
'skipped 0',
'todo 0',
]
) {
assert.strictEqual(diagnostics.includes(entry), true);
}
});

it('should run with different cwd while in watch mode', async () => {
Expand Down