Skip to content

sqlite: remove unnecessary auto assignment #54686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Sep 5, 2024
Merged

sqlite: remove unnecessary auto assignment #54686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
sqlite: remove unnecessary auto assignment 
Assignment is not necessary here at all.
  • Loading branch information
@tniessen
tniessen committed Sep 1, 2024
commit 8eb40e58769c589e44c45fbb98cc4695d95cf152
8 changes: 4 additions & 4 deletions src/node_sqlite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo<Value>& args) {
return;
}

auto sql = node::Utf8Value(env->isolate(), args[0].As<String>());
node::Utf8Value sql(env->isolate(), args[0].As<String>());
sqlite3_stmt* s = nullptr;
int r = sqlite3_prepare_v2(db->connection_, *sql, -1, &s, 0);
CHECK_ERROR_OR_THROW(env->isolate(), db->connection_, r, SQLITE_OK, void());
Expand All @@ -234,7 +234,7 @@ void DatabaseSync::Exec(const FunctionCallbackInfo<Value>& args) {
return;
}

auto sql = node::Utf8Value(env->isolate(), args[0].As<String>());
node::Utf8Value sql(env->isolate(), args[0].As<String>());
int r = sqlite3_exec(db->connection_, *sql, nullptr, nullptr, nullptr);
CHECK_ERROR_OR_THROW(env->isolate(), db->connection_, r, SQLITE_OK, void());
}
Expand Down Expand Up @@ -322,7 +322,7 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
return false;
}

auto utf8_key = node::Utf8Value(env()->isolate(), key);
node::Utf8Value utf8_key(env()->isolate(), key);
int r = sqlite3_bind_parameter_index(statement_, *utf8_key);
if (r == 0) {
if (allow_bare_named_params_) {
Expand Down Expand Up @@ -378,7 +378,7 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
double val = value.As<Number>()->Value();
r = sqlite3_bind_double(statement_, index, val);
} else if (value->IsString()) {
auto val = node::Utf8Value(env()->isolate(), value.As<String>());
node::Utf8Value val(env()->isolate(), value.As<String>());
r = sqlite3_bind_text(
statement_, index, *val, val.length(), SQLITE_TRANSIENT);
} else if (value->IsNull()) {
Expand Down