Skip to content

path: fix win32 relative() when "to" is a prefix #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
omsmith wants to merge 3 commits into from
Closed

path: fix win32 relative() when "to" is a prefix #5456

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c18d24e
path: fix win32 relative() when "to" is a prefix
omsmith Feb 26, 2016
80fd741
path: fix win32 relative() for UNC paths
omsmith Feb 26, 2016
e3f3679
test: add test-cases for posix path.relative()
omsmith Feb 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add test-cases for posix path.relative() 
adds posix test cases for paths similar to those that caused #5447
  • Loading branch information
@omsmith
omsmith committed Feb 27, 2016
commit e3f3679faf3242a7cc3acf3e6ea2bc799a5386e1
4 changes: 3 additions & 1 deletion test/parallel/test-path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,9 @@ const relativeTests = [
['/var/', '/var/lib', 'lib'],
['/', '/var/lib', 'var/lib'],
['/foo/test', '/foo/test/bar/package.json', 'bar/package.json'],
['/Users/a/web/b/test/mails', '/Users/a/web/b', '../..']
['/Users/a/web/b/test/mails', '/Users/a/web/b', '../..'],
['/foo/bar/baz-quux', '/foo/bar/baz', '../baz'],
['/foo/bar/baz', '/foo/bar/baz-quux', '../baz-quux']
]
]
];
Expand Down