Skip to content

lib: ensure no holey array in fixed_queue #54537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 2, 2024
Merged

lib: ensure no holey array in fixed_queue #54537

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f3a09d
lib: ensure no holey array in fixed_queue
jazelly Aug 25, 2024
348536f
add a test
jazelly Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add a test
  • Loading branch information
@jazelly
jazelly committed Aug 27, 2024
commit 348536f113873a62171ad382e62df018fcb65e5b
12 changes: 12 additions & 0 deletions test/parallel/test-fixed-queue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,15 @@ const FixedQueue = require('internal/fixed_queue');
assert.strictEqual(queue.shift(), 'a');
assert(queue.isEmpty());
}

{
// FixedQueue must not be holey array
// Refs: https://github.com/nodejs/node/issues/54472
const queue = new FixedQueue();
for (let i = 0; i < queue.head.list.length; i++) {
assert(i in queue.head.list);
}
for (let i = 0; i < queue.tail.list.length; i++) {
assert(i in queue.tail.list);
}
}