Skip to content

repl: catch \v and \r in new-line detection #54512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Sep 25, 2024
Merged

repl: catch \v and \r in new-line detection #54512

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66b6cc1
repl: catch `\v` and `\r` in new-line detection
avivkeller Aug 22, 2024
19c6ac2
disable if no inspector
avivkeller Aug 31, 2024
84cf466
fixup!
avivkeller Sep 23, 2024
500c5ee
fixup! fixup!
avivkeller Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@avivkeller @aduh95
avivkeller and aduh95 committed Sep 23, 2024
commit 84cf4668ee906bdc91d5ed717898722773eabfa4
8 changes: 3 additions & 5 deletions test/parallel/test-repl-preview-newlines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@ repl.start({
let output = '';
outputStream.write = (chunk) => output += chunk;

const testChars = ['\\n', '\\v', '\\r'];

for (const test of testChars) {
inputStream.emit('data', `"${test}"()`);
for (const testChar of '\n\v\r') {
inputStream.emit('data', `${JSON.stringify(testChar)}()`);
// Make sure the output is on a single line
assert.strictEqual(output, `"${test}"()\n\x1B[90mTypeError: "\x1B[39m\x1B[9G\x1B[1A`);
assert.strictEqual(output, `${JSON.stringify(testChar)}()\n\x1B[90mTypeError: "\x1B[39m\x1B[9G\x1B[1A`);
inputStream.run(['']);
output = '';
}