Skip to content

src: add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE #54501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Aug 28, 2024
Merged

src: add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE #54501

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d270a8e
src: add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE
joyeecheung Aug 9, 2024
82f7e87
fixup! src: add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE
joyeecheung Aug 23, 2024
3bd39dd
fixup! fixup! src: add JS APIs for compile cache and NODE_DISABLE_COM…
joyeecheung Aug 23, 2024
ff7ba92
fixup! src: add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE
joyeecheung Aug 27, 2024
bd97c0a
fixup! src: add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE
joyeecheung Aug 28, 2024
73c03b1
fixup! src: add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE
joyeecheung Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! src: add JS APIs for compile cache and NODE_DISABLE_COM… 
…PILE_CACHE
  • Loading branch information
@joyeecheung
joyeecheung committed Aug 23, 2024
commit 3bd39dd1e2e3afe5404c0c10c52253b5b03436aa
7 changes: 4 additions & 3 deletions lib/internal/modules/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ const assert = require('internal/assert');

const { Buffer } = require('buffer');
const { getOptionValue } = require('internal/options');
const { setOwnProperty } = require('internal/util');
const { setOwnProperty, getLazy } = require('internal/util');
const { inspect } = require('internal/util/inspect');
const { tmpdir } = require('os');

const lazyTmpdir = getLazy(() => require('os').tmpdir());
const { join } = path;

const { canParse: URLCanParse } = internalBinding('url');
Expand Down Expand Up @@ -453,7 +454,7 @@ function stringify(body) {
*/
function enableCompileCache(cacheDir) {
if (cacheDir === undefined) {
cacheDir = join(tmpdir(), 'node-compile-cache');
cacheDir = join(lazyTmpdir(), 'node-compile-cache');
}
const nativeResult = _enableCompileCache(cacheDir);
const result = { status: nativeResult[0] };
Comment thread
joyeecheung marked this conversation as resolved.
Expand Down