Skip to content

test: mark 'test/parallel/test-sqlite.js' as flaky #54031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 25, 2024
Merged

test: mark 'test/parallel/test-sqlite.js' as flaky #54031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: mark 'test/parallel/test-sqlite.js' as flaky 
The current test is large and can time out. It should be split
into multiple smaller tests as done in #54014. However, that
approach appears to change GC behavior such that the database
files are not cleaned up quickly enough on Windows. Forcing
any unfinalized SQL statements to be GC'ed appears to fix the
problem. Mark the original test as flaky until the necessary
code changes are made.
  • Loading branch information
@cjihrig
cjihrig committed Jul 25, 2024
commit 72ed735dac19e7d68f7c3a552ad8fda702a19fa1
3 changes: 3 additions & 0 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ test-fs-read-stream-concurrent-reads: PASS, FLAKY
# https://github.com/nodejs/node/issues/52630
test-error-serdes: PASS, FLAKY

# https://github.com/nodejs/node/issues/54006
test-sqlite: PASS, FLAKY

[$system==win32]

# Windows on ARM
Expand Down