Skip to content

build, tools: drop leading / from r2dir #53951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 22, 2024
Merged

build, tools: drop leading / from r2dir #53951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build, tools: drop leading / from r2dir 
The script is commented as removing `/home/dist/` part but the `cut`
command is off by one and end up including the `/` character (so that
the resulting string starts with `/`). When this is substituted into
`s3://${cloudflare_bucket}/${r2dir}/${shafile}.asc` we end up with
`//` (one from the template and one from the `r2dir`) which appears
to cause Cloudflare to create an extra top level `/` directory in the
bucket.
  • Loading branch information
@richardlau
richardlau committed Jul 19, 2024
commit b6d0df359a742f2b549d0b6099fb443c1ce26564
2 changes: 1 addition & 1 deletion tools/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ sign() {
# since the promotion script should take care of uploading them.

# Remove /home/dist/ part
r2dir=$(echo "$shadir" | cut -c 11-)
r2dir=$(echo "$shadir" | cut -c 12-)

# Copy SHASUMS256.txt.asc
# shellcheck disable=SC2086,SC2029
Expand Down