Skip to content

test_runner: fix support watch with run(), add globPatterns option #53866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 24 commits into from
Jul 24, 2024
Merged

test_runner: fix support watch with run(), add globPatterns option #53866

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
70074ab
test_runner: fix support watch with run(), add globPatterns option
mcollina Jul 16, 2024
61675a0
fixup
mcollina Jul 16, 2024
5ed9505
fixup
mcollina Jul 16, 2024
895896f
fixup
mcollina Jul 18, 2024
37247a7
Apply suggestions from code review
mcollina Jul 18, 2024
807e473
fixup
mcollina Jul 18, 2024
aaa0f99
fixup
mcollina Jul 18, 2024
fb8003d
fixup
mcollina Jul 18, 2024
95eae04
fixup
mcollina Jul 18, 2024
5f9b0a2
fixup
mcollina Jul 18, 2024
8eddb4e
fixup
mcollina Jul 18, 2024
d7ad6ee
fixup
mcollina Jul 18, 2024
51ec7e2
Revert "fixup"
mcollina Jul 19, 2024
4a29e29
fixup
mcollina Jul 19, 2024
71df5bf
fixup
mcollina Jul 19, 2024
09785dc
fixup
mcollina Jul 19, 2024
182949d
Update test/parallel/test-runner-run-files-undefined.mjs
mcollina Jul 22, 2024
c761443
fixup
mcollina Jul 22, 2024
d290029
skipping test on aix
mcollina Jul 22, 2024
9b164ab
fixup
mcollina Jul 23, 2024
82bf7f2
fixup
mcollina Jul 23, 2024
cdf2a03
fixup
mcollina Jul 23, 2024
bd7d8e2
fixup
mcollina Jul 24, 2024
689bd6d
fixup
mcollina Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
  • Loading branch information
@mcollina @atlowChemi
mcollina and atlowChemi committed Jul 18, 2024
commit 37247a74390578d471627d79a680406848cfcee4
30 changes: 7 additions & 23 deletions test/parallel/test-runner-run-watch.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,31 +87,15 @@ async function testWatch({ fileToUpdate, file, action = 'update', cwd = tmpdir.p

for (const run of runs) {
assert.doesNotMatch(run, /run\(\) is being called recursively/);
assert.doesNotMatch(run, /MODULE_NOT_FOUND/);
assert.match(run, /# tests 1/);
assert.match(run, /# pass 1/);
assert.match(run, /# fail 0/);
assert.match(run, /# cancelled 0/);
}
};

const testRename2 = async () => {
await ran1.promise;
const fileToRenamePath = tmpdir.resolve(fileToUpdate);
const newFileNamePath = tmpdir.resolve(`test-renamed-${fileToUpdate}`);
const interval = setInterval(() => renameSync(fileToRenamePath, newFileNamePath), common.platformTimeout(1000));
await ran2.promise;
runs.push(currentRun);
clearInterval(interval);
child.kill();

for (const run of runs) {
assert.doesNotMatch(run, /run\(\) is being called recursively/);
if (action === 'rename2') {
assert.match(run, /MODULE_NOT_FOUND/);
} else {
assert.doesNotMatch(run, /MODULE_NOT_FOUND/);
}
assert.match(run, /# tests 1/);
assert.match(run, /# pass 1/);
assert.match(run, /# fail 0/);
assert.match(run, /# cancelled 0/);
assert.match(run, /MODULE_NOT_FOUND/);
}
};
Comment thread
mcollina marked this conversation as resolved.

Expand Down Expand Up @@ -163,7 +147,7 @@ describe('test runner watch mode', () => {
await testWatch({ fileToUpdate: 'test.js', action: 'rename' });
});

it('should not throw when delete a watched test file', async () => {
it('should not throw when deleting a watched test file', async () => {
await testWatch({ fileToUpdate: 'test.js', action: 'delete' });
});

Expand All @@ -176,7 +160,7 @@ describe('test runner watch mode', () => {
});
});

it('should handle ranames in a different cwd', async () => {
it('should handle renames in a different cwd', async () => {
await testWatch({
file: join(tmpdir.path, 'test.js'),
fileToUpdate: 'test.js',
Expand Down