Skip to content

stream: improve inspector ergonomics #53800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 12, 2024
+4 −4
Merged

stream: improve inspector ergonomics #53800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
stream: improve inspector ergonomics
  • Loading branch information
@benjamingr
benjamingr committed Jul 10, 2024
commit 528b1354efd992be13baf940f39fe4b17b7e026b
4 changes: 2 additions & 2 deletions lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2041,8 +2041,8 @@ function readableStreamError(stream, error) {
assert(stream[kState].state === 'readable');
stream[kState].state = 'errored';
stream[kState].storedError = error;
stream[kIsClosedPromise].reject(error);
setPromiseHandled(stream[kIsClosedPromise].promise);
stream[kIsClosedPromise].reject(error);

const {
reader,
Expand All @@ -2051,8 +2051,8 @@ function readableStreamError(stream, error) {
if (reader === undefined)
return;

reader[kState].close.reject(error);
setPromiseHandled(reader[kState].close.promise);
reader[kState].close.reject(error);

if (readableStreamHasDefaultReader(stream)) {
for (let n = 0; n < reader[kState].readRequests.length; n++)
Expand Down
4 changes: 2 additions & 2 deletions lib/internal/webstreams/writablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,15 +768,15 @@ function writableStreamRejectCloseAndClosedPromiseIfNeeded(stream) {
};
}

stream[kIsClosedPromise].reject(stream[kState]?.storedError);
setPromiseHandled(stream[kIsClosedPromise].promise);
stream[kIsClosedPromise].reject(stream[kState]?.storedError);

const {
writer,
} = stream[kState];
if (writer !== undefined) {
writer[kState].close.reject?.(stream[kState].storedError);
setPromiseHandled(writer[kState].close.promise);
writer[kState].close.reject?.(stream[kState].storedError);
}
}

Expand Down