Skip to content

meta: remove redudant logging from dep updaters #53783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jul 14, 2024
Merged

meta: remove redudant logging from dep updaters #53783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dae1d3
meta: remove redudant logging from dep updaters
avivkeller Jul 9, 2024
8aa216d
Update update-gyp-next.sh
avivkeller Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
meta: remove redudant logging from dep updaters
  • Loading branch information
@avivkeller
avivkeller committed Jul 9, 2024
commit 8dae1d365a7809d203196db283b48e9f41c841a4
8 changes: 0 additions & 8 deletions tools/dep_updaters/update-acorn-walk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ tar -xf "$ACORN_WALK_TGZ"

mv package/* "$DEPS_DIR/acorn/acorn-walk"

echo "All done!"
echo ""
echo "Please git add acorn-walk, commit the new version:"
echo ""
echo "$ git add -A deps/acorn-walk"
echo "$ git commit -m \"deps: update acorn-walk to $NEW_VERSION\""
echo ""

# Update the version number on maintaining-dependencies.md
# and print the new version as the last line of the script as we need
# to add it to $GITHUB_ENV variable
Expand Down
9 changes: 0 additions & 9 deletions tools/dep_updaters/update-acorn.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,6 @@ cat > "$BASE_DIR/src/acorn_version.h" <<EOF
#endif // SRC_ACORN_VERSION_H_
EOF

echo "All done!"
echo ""
echo "Please git add acorn, commit the new version:"
echo ""
echo "$ git add -A deps/acorn/acorn"
echo "$ git add $BASE_DIR/src/acorn_version.h"
echo "$ git commit -m \"deps: update acorn to $NEW_VERSION\""
echo ""

# Update the version number on maintaining-dependencies.md
# and print the new version as the last line of the script as we need
# to add it to $GITHUB_ENV variable
Expand Down
8 changes: 0 additions & 8 deletions tools/dep_updaters/update-gyp-next.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,6 @@ rm -rf "$BASE_DIR/tools/gyp"

mv "$WORKSPACE/gyp" "$BASE_DIR/tools/"

echo "All done!"
echo ""
echo "Please git add gyp-next and commit the new version:"
echo ""
echo "$ git add -A tools/gyp"
Comment thread
avivkeller marked this conversation as resolved.
echo "$ git commit -m \"tools: update gyp-next to $NEW_VERSION\""
echo ""

# The last line of the script should always print the new version,
# as we need to add it to $GITHUB_ENV variable.
echo "NEW_VERSION=$NEW_VERSION"
8 changes: 0 additions & 8 deletions tools/dep_updaters/update-minimatch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,6 @@ rm -rf node_modules

mv ./* "$DEPS_DIR/minimatch"

echo "All done!"
echo ""
echo "Please git add minimatch, commit the new version:"
echo ""
echo "$ git add -A deps/minimatch"
echo "$ git commit -m \"deps: update minimatch to $NEW_VERSION\""
echo ""

# Update the version number on maintaining-dependencies.md
# and print the new version as the last line of the script as we need
# to add it to $GITHUB_ENV variable
Expand Down