Skip to content

lib: remove path.resolve from permissions.js #53729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 8, 2024
Merged

lib: remove path.resolve from permissions.js #53729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: remove path.resolve from permissions.js
  • Loading branch information
@RafaelGSS
RafaelGSS committed Jul 4, 2024
commit 1f2fe1ed90cf233f081665cc9f8d17060b9de80d
5 changes: 0 additions & 5 deletions lib/internal/process/permission.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@

const {
ObjectFreeze,
StringPrototypeStartsWith,
} = primordials;

const permission = internalBinding('permission');
const { validateString } = require('internal/validators');
const { resolve } = require('path');

let experimentalPermission;

Expand All @@ -25,9 +23,6 @@ module.exports = ObjectFreeze({
if (reference != null) {
// TODO: add support for WHATWG URLs and Uint8Arrays.
validateString(reference, 'reference');
if (StringPrototypeStartsWith(scope, 'fs')) {
reference = resolve(reference);
}
}

return permission.has(scope, reference);
Expand Down