Skip to content

meta: request reviews from github actions #53149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avivkeller wants to merge 5 commits into from
Closed

meta: request reviews from github actions #53149

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8addb50
meta: request reviews from github actions
avivkeller May 25, 2024
d7c988e
Handle deps somewhere else
avivkeller Jun 17, 2024
96f9077
Update pr-open.js
avivkeller Jun 17, 2024
2082ceb
Update pr-open.js
avivkeller Jul 14, 2024
89af870
Update pr-open.js
avivkeller Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle deps somewhere else
  • Loading branch information
@avivkeller
avivkeller authored Jun 17, 2024
commit d7c988efde1055e1cf170d7507202b9bd597d4f7
20 changes: 0 additions & 20 deletions tools/actions/pr-open.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,22 +52,6 @@ module.exports = async (client, context) => {
return new CodeOwners(content);
}

function shouldPingTSC(changedFiles) {
const user = context.payload.sender.login;
if (user === 'nodejs-github-bot') {
return false;
}

const TSC_FILE_PATHS = [
globToRegex('/deps/**'),
];

return changedFiles.some((filePath) => {
const normalizedPath = filePath.startsWith('/') ? filePath : `/${filePath}`;
return TSC_FILE_PATHS.some((pattern) => pattern.test(normalizedPath));
});
}

async function makeInitialComment(changedFiles) {
const codeOwners = await getCodeOwners();

Expand All @@ -87,10 +71,6 @@ module.exports = async (client, context) => {
'Please be patient and wait for them to review your changes.\n\n' +
"If you have any questions, please don't hesitate to ask!";

if (shouldPingTSC(changedFiles)) {
body += '\n\nA modification in this PR may require @nodejs/tsc\'s approval.';
}

return client.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down