Skip to content

doc: improve ninja build for --built-in-modules-path #53007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
May 17, 2024
Merged

doc: improve ninja build for --built-in-modules-path #53007

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
562db7d
doc: improve ninja build for --built-in-modules-path
jakecastelli May 15, 2024
a3e30ce
Update doc/contributing/building-node-with-ninja.md
jakecastelli May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: improve ninja build for --built-in-modules-path 
The current ninja build does not work with `--node-builtin-modules-path`
flag without passing `--ninja` as it will use `make` to build from
scratch again.
  • Loading branch information
@jakecastelli
jakecastelli committed May 16, 2024
commit 562db7d0879639d737d0f9b84cf2b6833345008d
6 changes: 6 additions & 0 deletions doc/contributing/building-node-with-ninja.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ doing so can be significantly quicker than using `make`. Please see
[Ninja][] is supported in the Makefile. Run `./configure --ninja` to configure
the project to run the regular `make` commands with Ninja.

If you wish to only modify JS layer in `lib`, you can use:
Comment thread
jakecastelli marked this conversation as resolved.
Outdated

```bash
./configure --ninja --node-builtin-modules-path "$(pwd)"
```

For example, `make` will execute `ninja -C out/Release` internally
to produce a compiled release binary, It will also execute
`ln -fs out/Release/node node`, so that you can execute `./node` at
Expand Down