Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
014bf01
lib: replace string prototype usage with alternatives
avivkeller Apr 11, 2024
61e1ac0
crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
codebytere Apr 11, 2024
8738b89
deps: upgrade npm to 10.5.2
npm-cli-bot Apr 12, 2024
44ee04c
buffer: improve `base64` and `base64url` performance
anonrig Apr 12, 2024
f6145aa
lib: convert WeakMaps in cjs loader with private symbol properties
legendecas Apr 12, 2024
fdcde84
lib: refactor lazy loading of undici for fetch method
Apr 12, 2024
9b18df9
url: implement parse method for safer URL parsing
thisalihassan Apr 13, 2024
8ae1507
tools: add a linter for README lists
aduh95 Apr 13, 2024
dfda6fe
buffer: add missing ARG_TYPE(ArrayBuffer) for isUtf8
Apr 13, 2024
7b82c17
benchmark: add ipc support to spawn stdio config
thisalihassan Apr 10, 2024
7cdfe8a
benchmark: inherit stdio/stderr instead of pipe
thisalihassan Apr 10, 2024
b00766d
module: tidy code and comments
JakobJingleheimer Apr 13, 2024
b4ccb6c
test_runner: move end of work check to finalize()
cjihrig Apr 12, 2024
3287553
test_runner: don't exceed call stack when filtering
cjihrig Apr 12, 2024
e70d8a4
meta: move one or more collaborators to emeritus
nodejs-github-bot Apr 14, 2024
dc399dd
lib, doc: rename readme.md to README.md
avivkeller Apr 14, 2024
15c5686
tools: update minimatch index path
marco-ippolito Apr 15, 2024
e34e0a9
test: write tests for assertIsArray http2 util
sinansonmez Apr 15, 2024
e066ba2
test_runner: better error handing for test hook
himself65 Apr 15, 2024
4e5ce3a
tools: use stylistic ESLint plugin for formatting
targos Apr 15, 2024
1fca8ba
node-api: copy external type tags when they are set
Koromix Apr 15, 2024
7e93c48
doc: update test runner coverage limitations
MoLow Apr 15, 2024
6b4bbfb
tools: update lint-md-dependencies to rollup@4.14.2 vfile-reporter@8.1.1
nodejs-github-bot Apr 16, 2024
d67a9a5
deps: update minimatch to 9.0.4
nodejs-github-bot Apr 16, 2024
9794d21
module: fix submodules loaded by require() and import()
joyeecheung Apr 16, 2024
f283d27
src: fix loadEnvFile ENOENT error
fahrradflucht Apr 17, 2024
ac04c64
src: remove regex usage for env file parsing
IlyasShabi Apr 17, 2024
d79ae74
net: add CLI option for autoSelectFamilyAttemptTimeout
ShogunPanda Apr 17, 2024
df61feb
tools: fix heading spaces for osx-entitlements.plist
JacksonTian Apr 17, 2024
18aa5d6
test: split wasi poll test for windows
huseyinacacak-janea Apr 17, 2024
3c37ce5
dns: add order option and support ipv6first
ShogunPanda Apr 17, 2024
63cc2b8
doc: fix issue detected in markdown lint update
Trott Apr 17, 2024
35643c1
benchmark: reduce the buffer size for blob
debadree25 Apr 17, 2024
9a44059
deps: update zlib to 1.3.0.1-motley-7d77fb7
nodejs-github-bot Apr 17, 2024
4d77fd2
module: implement NODE_COMPILE_CACHE for automatic on-disk code caching
joyeecheung Feb 29, 2024
c8c6173
test: fix test-tls-ticket-cluster.js
huseyinacacak-janea Apr 18, 2024
e247a61
test_runner: add --test-skip-pattern cli option
avivkeller Apr 18, 2024
ed080d8
test: ensure that all worker servers are ready
lpinca Apr 19, 2024
a7e03d3
fs: fixes recursive fs.watch crash on Linux when deleting files
mcollina Apr 19, 2024
a56faff
src: parse inspector profiles with simdjson
joyeecheung Feb 16, 2024
3df3afc
module: detect ESM syntax by trying to recompile as SourceTextModule
joyeecheung Apr 19, 2024
80cbe72
deps: update undici to 6.13.0
nodejs-github-bot Apr 19, 2024
552642a
tools: update lint-md-dependencies
Trott Apr 19, 2024
27ffa35
doc: add RedYetiDev to triage team
avivkeller Apr 20, 2024
910533f
crypto: simplify assertions in Safe*Print
davidben Apr 20, 2024
9ffdcad
lib: use predefined variable instead of bit operation
deokjinkim Apr 20, 2024
a93f5d4
doc: correct stream.finished changes
climba03003 Apr 20, 2024
5b52a48
deps: update icu to 75.1
nodejs-github-bot Apr 21, 2024
fb4edf7
quic: rework TLSContext, additional cleanups
jasnell Dec 31, 2023
d40e4d4
deps: update ada to 2.7.8
nodejs-github-bot Apr 14, 2024
31831e9
doc: sort options alphabetically
lpinca Apr 21, 2024
c83526a
doc: replace U+00A0 with U+0020
lpinca Apr 21, 2024
eeb80ad
doc: correct unsafe URL example in http docs
mlegenhausen Apr 21, 2024
f9ddd77
tools: add lint rule to keep primordials in ASCII order
aduh95 Apr 21, 2024
3552829
doc: add info on contributor spotlight program
mhdawson Apr 19, 2024
f23fa1d
fs: fix read / readSync positional offset types
ruyadorno Apr 22, 2024
3b422dd
deps: update corepack to 0.28.0
nodejs-github-bot Apr 23, 2024
382d951
tools: update lint-md-dependencies to rollup@4.15.0
nodejs-github-bot Apr 23, 2024
3026401
events,doc: mark CustomEvent as stable
daeyeon Apr 23, 2024
01103a8
tools: fix invalid escape sequence in mkssldef
targos Apr 23, 2024
d1adc9b
lib: enforce ASCII order in error code imports
aduh95 Apr 23, 2024
04c8e11
doc: run license-builder
github-actions[bot] Apr 24, 2024
20c07e9
meta: move one or more collaborators to emeritus
nodejs-github-bot Apr 24, 2024
4d577fa
doc: add .gitattributes for md files
huseyinacacak-janea Mar 26, 2024
b2f754c
test: skip test-fs-watch-recursive-delete.js on IBM i
abmusse Apr 24, 2024
43fa6a1
src: add `string_view` overload to snapshot FromBlob
addaleax Apr 24, 2024
4baeb7b
build: fix arm64 cross-compilation bug on non-arm machines
mahdisharifithedev Apr 24, 2024
90c6e77
doc: fix info string causing duplicated code blocks
mleenhardt Apr 24, 2024
64428dc
lib, url: add a `windows` option to path parsing
avivkeller Apr 24, 2024
0b97031
typings: fix invalid JSDoc declarations
anonrig Apr 24, 2024
10596e2
test: fix backtick usage in docs
avivkeller Apr 24, 2024
9a032cf
doc: remove relative limitation to pm
RafaelGSS Apr 24, 2024
9b2b6ab
lib,src: iterate module requests of a module wrap in JS
legendecas Apr 25, 2024
4f713fb
build: fix headers install for shared mode on Win
segevfiner Mar 30, 2024
544c602
module: skip NODE_COMPILE_CACHE when policy is enabled
joyeecheung Apr 25, 2024
e20d2f1
src: cast to v8::Value before using v8::EmbedderGraph::V8Node
joyeecheung Apr 25, 2024
d33131a
vm: fix ASCII-betical order
avivkeller Apr 25, 2024
d5cd468
build,tools,node-api: fix building node-api tests for Windows Debug
vmoroz Apr 26, 2024
b17cfea
node-api: address coverity report
mhdawson Apr 26, 2024
db421bd
tools: take co-authors into account in `find-inactive-collaborators`
aduh95 Apr 26, 2024
45f7002
test: mark test as flaky
mhdawson Apr 26, 2024
27a5f94
deps: V8: cherry-pick 500de8bd371b
richardlau Apr 26, 2024
c6e0fe2
fs: allow setting Stat date properties
nicolo-ribaudo Apr 28, 2024
9f9eca9
stream: update ongoing promise in async iterator return() method
MattiasBuelens Apr 28, 2024
d5ecb6c
http2: fix excessive CPU usage when using `allowHTTP1=true`
eugene1g Apr 28, 2024
d568a9a
test: mark `test-error-serdes` as flaky
aduh95 Apr 28, 2024
c64a1a3
build: fix typo in node.gyp
targos Apr 29, 2024
d086ab4
quic: address recent coverity warnings
mhdawson Apr 22, 2024
20ab8f2
module: support ESM detection in the CJS loader
joyeecheung Apr 29, 2024
896a80e
meta: standardize regex
avivkeller Apr 29, 2024
2ef9380
tools: update lint-md-dependencies to rollup@4.17.0
nodejs-github-bot Apr 30, 2024
c6fe433
src,permission: throw async errors on async APIs
RafaelGSS Apr 30, 2024
8e4fd28
deps,src: simplify base64 encoding
lemire Apr 30, 2024
c0b58e0
doc: remove mold use on mac for speeding up build
congzhangzh Mar 28, 2024
3987a28
doc: update process.versions properties
IlyasShabi Apr 30, 2024
0c58d03
src: remove misplaced windows code under posix guard in node.cc
thisalihassan Apr 15, 2024
6e98eee
deps: upgrade npm to 10.7.0
npm-cli-bot May 1, 2024
87b87a8
2024-05-02, Version 22.1.0 (Current)
aduh95 Apr 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fs: fix read / readSync positional offset types
This changeset fixes the types in comments to match the implementation.

PR-URL: #52603
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
ruyadorno authored and aduh95 committed Apr 29, 2024
commit f23fa1de72c4007deba2fcbb356d4397e68f7507
8 changes: 6 additions & 2 deletions lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,11 @@ function openAsBlob(path, options = kEmptyObject) {
* Reads file from the specified `fd` (file descriptor).
* @param {number} fd
* @param {Buffer | TypedArray | DataView} buffer
* @param {number} offsetOrOptions
* @param {number | {
* offset?: number;
* length?: number;
* position?: number | bigint | null;
* }} [offsetOrOptions]
* @param {number} length
* @param {number | bigint | null} position
* @param {(
Expand Down Expand Up @@ -693,7 +697,7 @@ ObjectDefineProperty(read, kCustomPromisifyArgsSymbol,
* specified `fd` (file descriptor).
* @param {number} fd
* @param {Buffer | TypedArray | DataView} buffer
* @param {{
* @param {number | {
* offset?: number;
* length?: number;
* position?: number | bigint | null;
Expand Down