Skip to content

src: fix Worker termination in inspector.waitForDebugger #52527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 9 commits into from
May 13, 2024
+91 −1
Merged

src: fix Worker termination in inspector.waitForDebugger #52527

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
de5f1b7
src: fix Worker termination in `inspector.waitForDebugger`
daeyeon Apr 14, 2024
6a0142e
fixup! src: fix Worker termination in `inspector.waitForDebugger`
daeyeon Apr 14, 2024
5035b9c
fixup! fixup! src: fix Worker termination in `inspector.waitForDebugger`
daeyeon Apr 15, 2024
9c210e9
separate tc for clarify on patch expectations
daeyeon Apr 15, 2024
fcbd1b3
fixup! separate tc for clarify on patch expectations
daeyeon Apr 16, 2024
e500544
fixup! fixup! separate tc for clarify on patch expectations
daeyeon Apr 16, 2024
35002b6
fixup! fixup! fixup! separate tc for clarify on patch expectations
daeyeon Apr 17, 2024
ee7472d
fixup! fixup! fixup! fixup! separate tc for clarify on patch expectat…
daeyeon Apr 17, 2024
d7a556c
fixup! fixup! fixup! fixup! fixup! separate tc for clarify on patch e…
daeyeon Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! fixup! fixup! fixup! separate tc for clarify on patch e… 
…xpectations

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
  • Loading branch information
@daeyeon
daeyeon committed Apr 17, 2024
commit d7a556c021c1d57087420089398c991377858cc5
16 changes: 10 additions & 6 deletions test/parallel/test-inspector-exit-worker-in-wait-for-connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,36 @@
const common = require('../common');
common.skipIfInspectorDisabled();

const { parentPort, isMainThread, Worker } = require('node:worker_threads');
const { parentPort, workerData, Worker } = require('node:worker_threads');
if (!workerData) {
common.skipIfWorker();
}

const inspector = require('node:inspector');
const assert = require('node:assert');

// Refs: https://github.com/nodejs/node/issues/52467

let TIMEOUT = common.platformTimeout(5000);
if (common.isWindows) {
// Refs: https://github.com/nodejs/build/issues/3014
TIMEOUT = common.platformTimeout(15000);
}

// Refs: https://github.com/nodejs/node/issues/52467

(async () => {
if (isMainThread) {
if (!workerData) {
// worker.terminate() should terminate the worker and the pending
// inspector.waitForDebugger().
{
const worker = new Worker(__filename);
const worker = new Worker(__filename, { workerData: {} });
await new Promise((r) => worker.on('message', r));
await new Promise((r) => setTimeout(r, TIMEOUT));
worker.on('exit', common.mustCall());
await worker.terminate();
}
// process.exit() should kill the process.
{
const worker = new Worker(__filename);
const worker = new Worker(__filename, { workerData: {} });
await new Promise((r) => worker.on('message', r));
await new Promise((r) => setTimeout(r, TIMEOUT));
process.on('exit', (status) => assert.strictEqual(status, 0));
Expand Down