Skip to content

test: simplify ASan build checks #52430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Apr 11, 2024
Merged

test: simplify ASan build checks #52430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fff52eb
test: simplify ASan build checks
targos Apr 9, 2024
bb7f700
fixup! test: simplify ASan build checks
targos Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! test: simplify ASan build checks 
isASan
  • Loading branch information
@targos
targos committed Apr 9, 2024
commit bb7f700078edab317e2cc50f24293eb5903c85f6
4 changes: 2 additions & 2 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ const isFreeBSD = process.platform === 'freebsd';
const isOpenBSD = process.platform === 'openbsd';
const isLinux = process.platform === 'linux';
const isOSX = process.platform === 'darwin';
const isAsan = process.config.variables.asan === 1;
const isASan = process.config.variables.asan === 1;
const isPi = (() => {
try {
// Normal Raspberry Pi detection is to find the `Raspberry Pi` string in
Expand Down Expand Up @@ -965,7 +965,7 @@ const common = {
hasMultiLocalhost,
invalidArgTypeHelper,
isAlive,
isAsan,
isASan,
isDumbTerminal,
isFreeBSD,
isLinux,
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-dh-leak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
if (common.isAsan)
if (common.isASan)
common.skip('ASan messes with memory measurements');

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-secure-heap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ if (!common.hasCrypto)
if (common.isWindows)
common.skip('Not supported on Windows');

if (common.isAsan)
if (common.isASan)
common.skip('ASan does not play well with secure heap allocations');

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-strace-openat-openssl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if (!common.hasCrypto)
common.skip('missing crypto');
if (!common.isLinux)
common.skip('linux only');
if (common.isAsan)
if (common.isASan)
common.skip('strace does not work well with address sanitizer builds');
if (spawnSync('strace').error !== undefined) {
common.skip('missing strace');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-v8-serialize-leak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ for (let i = 0; i < 1000000; i++) {
async function main() {
await common.gcUntil('RSS should go down', () => {
const after = process.memoryUsage.rss();
if (common.isAsan) {
if (common.isASan) {
console.log(`ASan: before=${before} after=${after}`);
return after < before * 10;
} else if (process.config.variables.node_builtin_modules_path) {
Expand Down
2 changes: 1 addition & 1 deletion test/pummel/test-vm-memleak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

const common = require('../common');

if (common.isAsan) {
if (common.isASan) {
common.skip('ASan messes with memory measurements');
}

Expand Down