Skip to content

buffer: improve base64 and base64url performance #52428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Apr 12, 2024
Merged

buffer: improve base64 and base64url performance #52428

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1670bc
buffer: improve `base64` and `base64url` performance
anonrig Apr 8, 2024
8e88778
fix: replace base64_to_binary to account for short inputs
lemire Apr 9, 2024
a2b60ac
lint
lemire Apr 9, 2024
edbeb50
optimization: fast one-byte case
lemire Apr 9, 2024
c3d6e4d
lint
lemire Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: replace base64_to_binary to account for short inputs
  • Loading branch information
@lemire
lemire committed Apr 9, 2024
commit 8e88778a21de9b55f1287e3435877828f312a0db
21 changes: 13 additions & 8 deletions src/string_bytes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,10 +348,11 @@ size_t StringBytes::Write(Isolate* isolate,
case BASE64URL:
if (str->IsExternalOneByte()) { // 8-bit case
auto ext = str->GetExternalOneByteStringResource();
size_t written_len = buflen;
auto result = simdutf::base64_to_binary_safe(
ext->data(), ext->length(), buf, buflen, simdutf::base64_url);
ext->data(), ext->length(), buf, written_len, simdutf::base64_url);
if (result.error == simdutf::error_code::SUCCESS) {
nbytes = result.count;
nbytes = written_len;
} else {
// The input does not follow the WHATWG forgiving-base64 specification
// adapted for base64url
Expand All @@ -360,13 +361,15 @@ size_t StringBytes::Write(Isolate* isolate,
}
} else {
String::Value value(isolate, str);
size_t written_len = buflen;
auto result =
simdutf::base64_to_binary(reinterpret_cast<const char16_t*>(*value),
simdutf::base64_to_binary_safe(reinterpret_cast<const char16_t*>(*value),
value.length(),
buf,
written_len,
simdutf::base64_url);
if (result.error == simdutf::error_code::SUCCESS) {
nbytes = result.count;
nbytes = written_len;
} else {
// The input does not follow the WHATWG forgiving-base64 specification
// (adapted for base64url with + and / replaced by - and _).
Expand All @@ -379,24 +382,26 @@ size_t StringBytes::Write(Isolate* isolate,
case BASE64: {
if (str->IsExternalOneByte()) { // 8-bit case
auto ext = str->GetExternalOneByteStringResource();
size_t written_len = buflen;
auto result = simdutf::base64_to_binary_safe(
ext->data(), ext->length(), buf, buflen);
ext->data(), ext->length(), buf, written_len);
if (result.error == simdutf::error_code::SUCCESS) {
nbytes = buflen;
nbytes = written_len;
} else {
// The input does not follow the WHATWG forgiving-base64 specification
// https://infra.spec.whatwg.org/#forgiving-base64-decode
nbytes = base64_decode(buf, buflen, ext->data(), ext->length());
}
} else {
String::Value value(isolate, str);
size_t written_len = buflen;
auto result = simdutf::base64_to_binary_safe(
reinterpret_cast<const char16_t*>(*value),
value.length(),
buf,
buflen);
written_len);
if (result.error == simdutf::error_code::SUCCESS) {
nbytes = buflen;
nbytes = written_len;
} else {
// The input does not follow the WHATWG base64 specification
// https://infra.spec.whatwg.org/#forgiving-base64-decode
Expand Down