Skip to content

benchmark: conditionally use spawn with taskset for CPU pinning #52253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Apr 6, 2024
Merged

benchmark: conditionally use spawn with taskset for CPU pinning #52253

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28c68f0
benchmark: conditionally use spawn with taskset for cpu pinning
thisalihassan Mar 28, 2024
a559149
benchmark: run lint
thisalihassan Mar 28, 2024
3270cef
benchmark: refactor code for benchmark cpu settings
thisalihassan Mar 29, 2024
d6b0a82
benchmark: prefer node import syntax for built-in child_process
thisalihassan Mar 30, 2024
e87f992
docs: update benchmarks md to explain CPUSET variable
thisalihassan Apr 5, 2024
5f700f5
benchmark: fix stdio on stderr for child process
thisalihassan Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
benchmark: conditionally use spawn with taskset for cpu pinning 
This change enhances the benchmarking tool by conditionally using the,
spawn method with taskset for CPU pinning, improving consistency of
benchmark results across different environments.

Fixes: #52233
  • Loading branch information
@thisalihassan
thisalihassan committed Mar 31, 2024
commit 28c68f063055cd73669006f326683abfe43feaa4
28 changes: 24 additions & 4 deletions benchmark/compare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const { fork } = require('child_process');
const { spawn, fork } = require('child_process');
const { inspect } = require('util');
const path = require('path');
const CLI = require('./_cli.js');
Expand Down Expand Up @@ -40,6 +40,12 @@ if (benchmarks.length === 0) {
return;
}

const cpuCoreSetting = cli.optional.set.find(s => s.startsWith('CPUCORE='));
let cpuCore = null;
if (cpuCoreSetting) {
cpuCore = cpuCoreSetting.split('=')[1];
Comment thread
thisalihassan marked this conversation as resolved.
Outdated
}

// Create queue from the benchmarks list such both node versions are tested
// `runs` amount of times each.
// Note: BenchmarkProgress relies on this order to estimate
Expand Down Expand Up @@ -70,9 +76,23 @@ if (showProgress) {
(function recursive(i) {
const job = queue[i];

const child = fork(path.resolve(__dirname, job.filename), cli.optional.set, {
execPath: cli.optional[job.binary],
});
const resolvedPath = path.resolve(__dirname, job.filename);
let child;
if (cpuCore !== null) {
const spawnArgs = ['-c', cpuCore, cli.optional[job.binary], resolvedPath, ...cli.optional.set];
child = spawn('taskset', spawnArgs, {
env: process.env,
stdio: ['inherit', 'pipe', 'ipc'],
});

child.stdout.on('data', (data) => {
process.stdout.write(data);
});
} else {
child = fork(resolvedPath, cli.optional.set, {
execPath: cli.optional[job.binary],
});
}

child.on('message', (data) => {
Comment thread
thisalihassan marked this conversation as resolved.
if (data.type === 'report') {
Expand Down
31 changes: 26 additions & 5 deletions benchmark/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const path = require('path');
const fork = require('child_process').fork;
const { spawn, fork } = require('child_process');
Comment thread
thisalihassan marked this conversation as resolved.
Outdated
const CLI = require('./_cli.js');

const cli = new CLI(`usage: ./node run.js [options] [--] <category> ...
Expand Down Expand Up @@ -34,16 +34,37 @@ if (!validFormats.includes(format)) {
return;
}

const cpuCoreSetting = cli.optional.set.find(s => s.startsWith('CPUCORE='));
let cpuCore = null;
if (cpuCoreSetting) {
cpuCore = cpuCoreSetting.split('=')[1];
}

if (format === 'csv') {
console.log('"filename", "configuration", "rate", "time"');
}

(function recursive(i) {
const filename = benchmarks[i];
const child = fork(
path.resolve(__dirname, filename),
cli.test ? ['--test'] : cli.optional.set,
);
const scriptPath = path.resolve(__dirname, filename);
const args = cli.test ? ['--test'] : cli.optional.set;

let child;

if (cpuCore !== null) {
child = spawn('taskset', [`-c`, cpuCore, `node`, scriptPath, ...args], {
stdio: ['inherit', 'pipe', 'ipc']
});

Comment thread
mcollina marked this conversation as resolved.
child.stdout.on('data', (data) => {
process.stdout.write(data);
});
} else {
child = fork(
scriptPath,
args,
);
}

if (format !== 'csv') {
console.log();
Expand Down