Skip to content

doc: update removeListener behaviour #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaibhav93 wants to merge 5 commits into from
Closed

doc: update removeListener behaviour #5201

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b91ac0
doc: update removeListener behaviour
vaibhav93 Feb 12, 2016
e7dffb0
doc: fix comment typo in events
vaibhav93 Feb 12, 2016
a21be7c
test: use mustCall instead of count variable
vaibhav93 Feb 12, 2016
b60d25f
doc: fix typo in events
vaibhav93 Feb 12, 2016
9ae5a70
doc: Improve wording for removeListener text
vaibhav93 Feb 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix comment typo in events 
Add spaces before beginning of comments.
  • Loading branch information
@vaibhav93
vaibhav93 committed Feb 12, 2016
commit e7dffb01dc85ddda6ea9014317a2e501d4731689
8 changes: 4 additions & 4 deletions test/parallel/test-event-emitter-remove-listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,13 @@ function listener4() {
e6.on('hello', listener3);
e6.on('hello', listener4);

//listener4 will still be called although it is removed by listener 3.
// listener4 will still be called although it is removed by listener 3.
e6.emit('hello');
//This is so because the interal listener array at time of emit
//was [listener3,listener4]
// This is so because the interal listener array at time of emit
// was [listener3,listener4]
assert.equal(count, 2);

count = 0;
//Interal listener array [listener3]
// Interal listener array [listener3]
e6.emit('hello');
assert.equal(count, 1);