Skip to content

doc: add some commonly used labels up front #52006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Mar 9, 2024
Merged

doc: add some commonly used labels up front #52006

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a2e923
doc: add some commonly used lables up gront
mhdawson Mar 7, 2024
d639859
Update doc/contributing/collaborator-guide.md
mhdawson Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add some commonly used lables up gront 
From the last onboarding session I think it would be
good to add two commonly used lables to the section
which is linked from the onboarding doc.

Signed-off-by: Michael Dawson <midawson@redhat.com>
  • Loading branch information
@mhdawson
mhdawson committed Mar 7, 2024
commit 5a2e92308e6993a08d1fa3b051b29489d254be3f
4 changes: 4 additions & 0 deletions doc/contributing/collaborator-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,9 +879,13 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` can help.

* `confirmed-bug`: Bugs you have verified
* `discuss`: Things that need larger discussion
* `fast-track`: PRs that need to land faster - see
Copy link
Copy Markdown
Member

@MoLow MoLow Mar 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if putting fast-track PRs that do not need to wait for 72 hours to land. (i.e. https://github.com/nodejs/node/labels/fast-track) into the markdown will automatically get the color

Copy link
Copy Markdown
Member Author

@mhdawson mhdawson Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoLow are we getting the color or the others but not for these?

[Waiting for approvals](#waiting-for-approvals)
* `feature request`: Any issue that requests a new feature
* `good first issue`: Issues suitable for newcomers to fix
* `meta`: Governance, policies, procedures, etc.
* `request-ci`: When this lable is added to a PR, it will be landed
automatically. See [Starting a Jenkins CI job](#starting-a-jenkins-ci-job)
Comment thread
mhdawson marked this conversation as resolved.
Outdated
* `tsc-agenda`: Open issues and pull requests with this label will be added to
the Technical Steering Committee meeting agenda

Expand Down