Skip to content

stream: do not defer construction by one microtick #52005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 5 commits into from
Closed

stream: do not defer construction by one microtick #52005

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6e2284
fs: defer the writestream 'open' event by a nextTick
mcollina Mar 7, 2024
97beaa0
fixup
mcollina Mar 7, 2024
f94cf99
fixup
mcollina Mar 7, 2024
50e0c3c
fixup
mcollina Mar 8, 2024
3a44346
fixup
mcollina Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
  • Loading branch information
@mcollina
mcollina committed Mar 8, 2024
commit 50e0c3c77aac31cd0d8bca03cd0ad36126bba92b
6 changes: 4 additions & 2 deletions test/parallel/test-fs-writestream-open-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
'use strict';

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const { strictEqual } = require('assert');
const { tmpdir } = require('os');
const { join } = require('path');
Comment thread
mcollina marked this conversation as resolved.
Outdated
const fs = require('fs');

// Regression test for https://github.com/nodejs/node/issues/51993

const file = join(tmpdir(), `test-fs-writestream-open-write-${process.pid}.txt`);
tmpdir.refresh();

const file = join(tmpdir.path, `test-fs-writestream-open-write.txt`);
Comment thread
mcollina marked this conversation as resolved.
Outdated

const w = fs.createWriteStream(file);

Expand Down