Skip to content

lib: only build the ESM facade for builtins when they are needed #51669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

lib: only build the ESM facade for builtins when they are needed #51669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2be93a1
lib: only build the ESM facade for builtins when they are needed
joyeecheung Feb 5, 2024
397aadb
benchmark: rename startup.js to startup-core.js
joyeecheung Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
benchmark: rename startup.js to startup-core.js 
It is easier to filter the core startup benchmark with this name.
  • Loading branch information
@joyeecheung
joyeecheung committed Feb 13, 2024
commit 397aadb3e1c2a919c282aa624c588f270c236418
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@

# Startup

/benchmark/misc/startup.js @nodejs/startup
/benchmark/misc/startup-* @nodejs/startup
/lib/internal/bootstrap/* @nodejs/startup
/src/node_builtins* @nodejs/startup
/src/node_realm* @nodejs/startup @nodejs/realm
Expand Down
0 benchmark/misc/startup.js → benchmark/misc/startup-core.js
View file
Open in desktop
File renamed without changes.