Skip to content

(vee-eight-4.9) replace usage of deprecated V8 APIs #5159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 15 commits into from
Closed

(vee-eight-4.9) replace usage of deprecated V8 APIs #5159

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
531f494
src: replace usage of deprecated ForceSet
targos Feb 8, 2016
c3129e6
src: replace usage of deprecated Compile
targos Feb 8, 2016
a0e7a0f
src: replace usage of deprecated CompileUnbound
targos Feb 8, 2016
58b5580
src: replace usage of deprecated Delete
targos Feb 8, 2016
4149423
src: replace usage of deprecated GetEndColumn
targos Feb 8, 2016
af8ee14
src: replace usage of deprecated Has
targos Feb 8, 2016
6b5ce3d
src: replace usage of deprecated HasOwnProperty
targos Feb 8, 2016
1c13bd5
src: replace usage of deprecated TerminateExecution
targos Feb 9, 2016
c0d494c
src: replace usage of deprecated CancelTerminateExecution
targos Feb 9, 2016
9a93d32
src: replace usage of deprecated SetMessageHandler
targos Feb 9, 2016
d912bf3
src: replace usage of deprecated GetDebugContext
targos Feb 9, 2016
3885a6c
src: replace usage of deprecated ProcessDebugMessages
targos Feb 9, 2016
693f905
fixup! src: replace usage of deprecated Compile
targos Feb 10, 2016
50c7203
fixup! src: replace usage of deprecated Has
targos Feb 10, 2016
722d310
fixup! src: replace usage of deprecated GetDebugContext
targos Feb 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: replace usage of deprecated ForceSet
  • Loading branch information
@targos
targos committed Feb 8, 2016
commit 531f4947a3ee92f9fe1cfbfde70b37dcaee04971
15 changes: 10 additions & 5 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2788,15 +2788,20 @@ void StopProfilerIdleNotifier(const FunctionCallbackInfo<Value>& args) {

#define READONLY_PROPERTY(obj, str, var) \
do { \
obj->ForceSet(OneByteString(env->isolate(), str), var, v8::ReadOnly); \
obj->DefineOwnProperty(env->context(), \
OneByteString(env->isolate(), str), \
var, \
v8::ReadOnly).FromJust(); \
} while (0)

#define READONLY_DONT_ENUM_PROPERTY(obj, str, var) \
do { \
obj->ForceSet(OneByteString(env->isolate(), str), \
var, \
static_cast<v8::PropertyAttribute>(v8::ReadOnly | \
v8::DontEnum)); \
obj->DefineOwnProperty(env->context(), \
OneByteString(env->isolate(), str), \
var, \
static_cast<v8::PropertyAttribute>(v8::ReadOnly | \
v8::DontEnum)) \
.FromJust(); \
} while (0)


Expand Down
6 changes: 5 additions & 1 deletion src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,13 +221,17 @@ NODE_EXTERN void RunAtExit(Environment* env);
#define NODE_DEFINE_CONSTANT(target, constant) \
do { \
v8::Isolate* isolate = target->GetIsolate(); \
v8::Local<v8::Context> context = isolate->GetCurrentContext(); \
v8::Local<v8::String> constant_name = \
v8::String::NewFromUtf8(isolate, #constant); \
v8::Local<v8::Number> constant_value = \
v8::Number::New(isolate, static_cast<double>(constant)); \
v8::PropertyAttribute constant_attributes = \
static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontDelete); \
(target)->ForceSet(constant_name, constant_value, constant_attributes); \
(target)->DefineOwnProperty(context, \
constant_name, \
constant_value, \
constant_attributes).FromJust(); \
} \
while (0)

Expand Down
8 changes: 4 additions & 4 deletions src/node_internals.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ struct sockaddr;
v8::String::NewFromUtf8(isolate, constant); \
v8::PropertyAttribute constant_attributes = \
static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontDelete); \
target->ForceSet(isolate->GetCurrentContext(), \
constant_name, \
constant_value, \
constant_attributes); \
target->DefineOwnProperty(isolate->GetCurrentContext(), \
constant_name, \
constant_value, \
constant_attributes).FromJust(); \
} while (0)

namespace node {
Expand Down