Skip to content

Release proposal: v5.5.1 (Stable) #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rvagg wants to merge 15 commits into from
Closed

Release proposal: v5.5.1 (Stable) #5141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9e4f94b
doc: add CTC meeting minutes 2016-01-27
rvagg Feb 3, 2016
e325ece
doc: minor improvement in OS docs
estliberitas Jan 31, 2016
28b3928
doc: add CTC meeting minutes 2016-01-20
rvagg Jan 27, 2016
6363264
doc: fix links order in Buffer doc
estliberitas Feb 4, 2016
e05bb40
tools: lint for spacing around unary operators
Trott Feb 3, 2016
d64e6e0
buffer: remove duplicated code in fromObject
entertainyou Jan 29, 2016
f8269fe
querystring: check that maxKeys is finite
Feb 4, 2016
1b49dfb
node_contextify: do not incept debug context
Feb 1, 2016
3effca6
test: mark flaky tests on Raspberry Pi
Trott Feb 4, 2016
3b960af
doc: fix typo in dgram doc
Trott Feb 6, 2016
853d73b
src: clean up usage of __proto__
JacksonTian Feb 4, 2016
fc3c32b
test: fix flaky test-dgram-pingpong
Trott Feb 5, 2016
f513e66
tools: lint for empty character classes in regex
Trott Feb 6, 2016
6f58bc5
doc: console is asynchronous unless it's a file
bnoordhuis Feb 7, 2016
7035d21
2016-02-09, Version 5.5.1 (Stable)
rvagg Feb 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix flaky test-dgram-pingpong 
There is no guarantee UDP messages will be received. Accommodate the
occasional dropped message.

This is a functionality test, not a performance benchmark. Speed up the
test by not sending 1500 messages across three ports.

Fixes: #4526
PR-URL: #5125
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@Trott @rvagg
Trott authored and rvagg committed Feb 8, 2016
commit fc3c32b5827ca7fe4faa8d97899a15757fcdc80f
1 change: 0 additions & 1 deletion test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ prefix sequential

[$system==linux]
test-vm-syntax-error-stderr : PASS,FLAKY
test-dgram-pingpong : PASS,FLAKY
test-http-regr-gh-2928 : PASS,FLAKY

[$system==macos]
Expand Down
85 changes: 21 additions & 64 deletions test/sequential/test-dgram-pingpong.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,89 +1,46 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var Buffer = require('buffer').Buffer;
var dgram = require('dgram');

var debug = false;
var tests_run = 0;
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');

function pingPongTest(port, host) {
var callbacks = 0;
var N = 500;
var count = 0;

var server = dgram.createSocket('udp4', function(msg, rinfo) {
if (debug) console.log('server got: ' + msg +
' from ' + rinfo.address + ':' + rinfo.port);

if (/PING/.exec(msg)) {
var buf = new Buffer(4);
buf.write('PONG');
server.send(buf, 0, buf.length,
rinfo.port, rinfo.address,
function(err, sent) {
callbacks++;
});
}
});
const server = dgram.createSocket('udp4', common.mustCall((msg, rinfo) => {
assert.strictEqual('PING', msg.toString('ascii'));
server.send('PONG', 0, 4, rinfo.port, rinfo.address);
}));

server.on('error', function(e) {
throw e;
});

server.on('listening', function() {
console.log('server listening on ' + port + ' ' + host);
console.log('server listening on ' + port);

const buf = new Buffer('PING');
const client = dgram.createSocket('udp4');

client.on('message', function(msg, rinfo) {
if (debug) console.log('client got: ' + msg +
' from ' + rinfo.address + ':' + rinfo.port);
assert.equal('PONG', msg.toString('ascii'));

count += 1;

if (count < N) {
client.send(buf, 0, buf.length, port, 'localhost');
} else {
client.send(buf, 0, buf.length, port, 'localhost', function() {
client.close();
});
}
});
client.on('message', function(msg) {
assert.strictEqual('PONG', msg.toString('ascii'));

client.on('close', function() {
console.log('client has closed, closing server');
assert.equal(N, count);
tests_run += 1;
client.close();
server.close();
assert.equal(N - 1, callbacks);
});

client.on('error', function(e) {
throw e;
});

console.log('Client sending to ' + port + ', localhost ' + buf);
client.send(buf, 0, buf.length, port, 'localhost', function(err, bytes) {
if (err) {
throw err;
}
console.log('Client sent ' + bytes + ' bytes');
});
count += 1;
console.log('Client sending to ' + port);

function clientSend() {
client.send('PING', 0, 4, port, 'localhost');
}

clientSend();
});
server.bind(port, host);
return server;
}

// All are run at once, so run on different ports
pingPongTest(common.PORT + 0, 'localhost');
pingPongTest(common.PORT + 1, 'localhost');
pingPongTest(common.PORT + 2);
//pingPongTest('/tmp/pingpong.sock');

process.on('exit', function() {
assert.equal(3, tests_run);
console.log('done');
});
const server = pingPongTest(common.PORT, 'localhost');
server.on('close', common.mustCall(pingPongTest.bind(undefined, common.PORT)));