Skip to content

streams: fixes for webstreams #51168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 20 commits into from
Dec 26, 2023
+251 −282
Merged

streams: fixes for webstreams #51168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
cb4e020
stream: fix code style
MattiasBuelens Dec 15, 2023
46022b8
stream: avoid PromiseResolve in ensureIsPromise
MattiasBuelens Dec 4, 2023
62fc1e1
stream: fix handling sync errors from source cancel and sink abort
MattiasBuelens Dec 4, 2023
19e8940
stream: check for promise only when constructing from source/sink/tra…
MattiasBuelens Dec 4, 2023
ab33b45
stream: fix TeeReadableStream
MattiasBuelens Dec 4, 2023
463f49a
stream: rename TeeReadableStream to InternalReadableStream
MattiasBuelens Dec 4, 2023
36324d5
stream: use internal ReadableStream for teeing byte streams
MattiasBuelens Dec 4, 2023
f0b1036
stream: use internal ReadableStream for ReadableStream.from()
MattiasBuelens Dec 4, 2023
3846bfe
stream: use internal streams for TransformStream
MattiasBuelens Dec 4, 2023
0d45e6f
stream: add helpers to create internal state
MattiasBuelens Dec 15, 2023
5df4f2e
stream: remove unused field in internal state
MattiasBuelens Dec 15, 2023
15b30ca
stream: fix validating callbacks
MattiasBuelens Dec 4, 2023
0bd501f
test: update expectations for streams wpt
MattiasBuelens Dec 15, 2023
112a717
stream: set __proto__ to null for internal state
MattiasBuelens Dec 15, 2023
b9a13b5
fixup! simplify ensureIsPromise
MattiasBuelens Dec 15, 2023
162cfdc
fixup! remove unused imports
MattiasBuelens Dec 15, 2023
a889e2c
fixup! whitespace
MattiasBuelens Dec 15, 2023
16a9cc7
fixup! code style
MattiasBuelens Dec 15, 2023
11e6f94
fixup! fix timing of ensureIsPromise
MattiasBuelens Dec 16, 2023
0c0e3c1
fixup! rename to invokePromiseCallback
MattiasBuelens Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! remove unused imports
  • Loading branch information
@MattiasBuelens
MattiasBuelens committed Dec 15, 2023
commit 162cfdc0d99568962e045865603f1889c4cfd631
1 change: 0 additions & 1 deletion lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const {
FunctionPrototypeCall,
MathMin,
NumberIsInteger,
ObjectCreate,
ObjectDefineProperties,
ObjectSetPrototypeOf,
Promise,
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/webstreams/transformstream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ const {
} = require('internal/webstreams/util');

const {
ReadableStream,
createReadableStream,
readableStreamDefaultControllerCanCloseOrEnqueue,
readableStreamDefaultControllerClose,
Expand All @@ -60,7 +59,6 @@ const {
} = require('internal/webstreams/readablestream');

const {
WritableStream,
createWritableStream,
writableStreamDefaultControllerErrorIfNeeded,
} = require('internal/webstreams/writablestream');
Expand Down