Skip to content

[v18.x backport] esm: use import attributes instead of import assertions #51136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolo-ribaudo wants to merge 5 commits into from
Closed

[v18.x backport] esm: use import attributes instead of import assertions #51136

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
909963e
deps: V8: cherry-pick a0fd3209dda8
nicolo-ribaudo Dec 12, 2023
5389c3a
deps: V8: cherry-pick ea996ad04a68
nicolo-ribaudo Dec 12, 2023
b9d4d7c
esm: use import attributes instead of import assertions
aduh95 Dec 12, 2023
9cb5138
vm: use import attributes instead of import assertions
aduh95 Dec 12, 2023
cc239fe
src: iterate on import attributes array correctly
targos Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick ea996ad04a68 
Original commit message:
    [import-attributes] Remove support for numeric keys

    During the 2023-09 TC39 meeting the proposal has been updated to remove support
    for bigint and float literals as import attribute keys, due to implementation
    difficulties in other engines and minimal added value for JS developers.

    GH issue: tc39/proposal-import-attributes#145

    Bug: v8:13856
    Change-Id: I0ede2bb10d6ca338a4b0870a1261ccbcd088c16f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4899760
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#90318}

Refs: v8/v8@ea996ad
  • Loading branch information
@nicolo-ribaudo
nicolo-ribaudo committed Dec 12, 2023
commit 5389c3a4e22211a9e69fda10db1a3e9c90f094b0
12 changes: 2 additions & 10 deletions deps/v8/src/parsing/parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,16 +1378,8 @@ ImportAssertions* Parser::ParseImportAssertClause() {
Expect(Token::LBRACE);

while (peek() != Token::RBRACE) {
const AstRawString* attribute_key = nullptr;
if (Check(Token::STRING) || Check(Token::SMI)) {
attribute_key = GetSymbol();
} else if (Check(Token::NUMBER)) {
attribute_key = GetNumberAsSymbol();
} else if (Check(Token::BIGINT)) {
attribute_key = GetBigIntAsSymbol();
} else {
attribute_key = ParsePropertyName();
}
const AstRawString* attribute_key =
Check(Token::STRING) ? GetSymbol() : ParsePropertyName();

Scanner::Location location = scanner()->location();

Expand Down