Skip to content

fs: use w flag for writeFileSync with utf8 encoding when flag not specified #50990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Dec 3, 2023
Merged

fs: use w flag for writeFileSync with utf8 encoding when flag not specified #50990

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c323642
fs: use default w flag for writeFileSync with utf8 encoding
MuriloKakazu Dec 1, 2023
aaa4edd
fs: add tests for writeFileSync with no flag
MuriloKakazu Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fs: add tests for writeFileSync with no flag
  • Loading branch information
@MuriloKakazu
MuriloKakazu committed Dec 1, 2023
commit aaa4edda7d2e16a284f893c9cb49459b1271e4d5
16 changes: 16 additions & 0 deletions test/parallel/test-fs-write-file-sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,22 @@ tmpdir.refresh();
assert.strictEqual(content, 'hello world!');
}

// Test writeFileSync with no flags
{
const utf8Data = 'hello world!';
for (const test of [
{ data: utf8Data },
{ data: utf8Data, options: { encoding: 'utf8' } },
{ data: Buffer.from(utf8Data, 'utf8').toString('hex'), options: { encoding: 'hex' } },
]) {
const file = tmpdir.resolve(`testWriteFileSyncNewFile_${Math.random()}.txt`);
fs.writeFileSync(file, test.data, test.options);

const content = fs.readFileSync(file, { encoding: 'utf-8' });
assert.strictEqual(content, utf8Data);
}
}

// Test writeFileSync with an invalid input
{
const file = tmpdir.resolve('testWriteFileSyncInvalid.txt');
Expand Down