Skip to content

tools: add staple to macOS notarized binaries #50625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Nov 11, 2023
Merged

tools: add staple to macOS notarized binaries #50625

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc7bf89
tools: add macOS notarization stapler
UlisesGascon Nov 8, 2023
b46a70e
tools: remove return from macOS notarize script
UlisesGascon Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: add macOS notarization stapler
  • Loading branch information
@UlisesGascon
UlisesGascon committed Nov 8, 2023
commit fc7bf89716e1a8ee6252967b65d98f567b0639e4
3 changes: 3 additions & 0 deletions tools/osx-notarize.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,6 @@ else
echo "Notarization node-$pkgid.pkg failed."
exit 1
fi

xcrun stapler staple "node-$pkgid.pkg"
Comment thread
UlisesGascon marked this conversation as resolved.
echo "Stapler was successful."