Skip to content

[v18.x] deps: update nghttp2 to 1.57.0 #50151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 6 commits into from
Closed

[v18.x] deps: update nghttp2 to 1.57.0 #50151

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76f4747
Revert "deps: update nghttp2 to 1.55.0"
richardlau Oct 11, 2023
985a204
deps: update nghttp2 to 1.53.0
nodejs-github-bot May 18, 2023
3902f5d
deps: update nghttp2 to 1.55.0
nodejs-github-bot Jul 14, 2023
dd75e44
deps: update nghttp2 to 1.55.1
nodejs-github-bot Jul 17, 2023
8a10c6e
deps: update nghttp2 to 1.56.0
nodejs-github-bot Sep 17, 2023
e7163c7
deps: update nghttp2 to 1.57.0
jasnell Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: update nghttp2 to 1.55.1 
PR-URL: #48790
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
  • Loading branch information
@nodejs-github-bot @richardlau
nodejs-github-bot authored and richardlau committed Oct 11, 2023
commit dd75e44f2f4900f0dfd29a79e19e117266d88a5a
4 changes: 2 additions & 2 deletions deps/nghttp2/lib/includes/nghttp2/nghttp2ver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@
* @macro
* Version number of the nghttp2 library release
*/
#define NGHTTP2_VERSION "1.55.0"
#define NGHTTP2_VERSION "1.55.1"

/**
* @macro
* Numerical representation of the version number of the nghttp2 library
* release. This is a 24 bit number with 8 bits for major number, 8 bits
* for minor and 8 bits for patch. Version 1.2.3 becomes 0x010203.
*/
#define NGHTTP2_VERSION_NUM 0x013700
#define NGHTTP2_VERSION_NUM 0x013701

#endif /* NGHTTP2VER_H */
10 changes: 5 additions & 5 deletions deps/nghttp2/lib/nghttp2_session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3296,6 +3296,7 @@ static ssize_t nghttp2_session_mem_send_internal(nghttp2_session *session,
if (rv < 0) {
int32_t opened_stream_id = 0;
uint32_t error_code = NGHTTP2_INTERNAL_ERROR;
int rv2 = 0;

DEBUGF("send: frame preparation failed with %s\n",
nghttp2_strerror(rv));
Expand Down Expand Up @@ -3338,19 +3339,18 @@ static ssize_t nghttp2_session_mem_send_internal(nghttp2_session *session,
}
if (opened_stream_id) {
/* careful not to override rv */
int rv2;
rv2 = nghttp2_session_close_stream(session, opened_stream_id,
error_code);

if (nghttp2_is_fatal(rv2)) {
return rv2;
}
}

nghttp2_outbound_item_free(item, mem);
nghttp2_mem_free(mem, item);
active_outbound_item_reset(aob, mem);

if (nghttp2_is_fatal(rv2)) {
return rv2;
}

if (rv == NGHTTP2_ERR_HEADER_COMP) {
/* If header compression error occurred, should terminiate
connection. */
Expand Down