Skip to content

lib: reduce overhead of blob clone #50110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Oct 17, 2023
Merged

lib: reduce overhead of blob clone #50110

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6702af
lib: reduce overhead of blob clone
H4ad Oct 10, 2023
4bc72cb
fixup! lib: reduce overhead of blob clone
H4ad Oct 11, 2023
ec65971
fixup! lib: reduce overhead of blob clone
H4ad Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib: reduce overhead of blob clone
  • Loading branch information
@H4ad
H4ad committed Oct 11, 2023
commit b6702af1fc40ec68ae5f7b7b5b23dbed07fc4eba
7 changes: 5 additions & 2 deletions benchmark/blob/clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,17 @@ const assert = require('assert');

const bench = common.createBenchmark(main, {
n: [50e3],
bytes: [128, 1024, 1024 ** 2],
});

let _cloneResult;

function main({ n }) {
function main({ n, bytes }) {
const buff = Buffer.allocUnsafe(bytes);
const blob = new Blob(buff);
bench.start();
for (let i = 0; i < n; ++i)
_cloneResult = structuredClone(new Blob(['hello']));
_cloneResult = structuredClone(blob);
bench.end(n);

// Avoid V8 deadcode (elimination)
Expand Down
22 changes: 12 additions & 10 deletions lib/internal/blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ class Blob {
const length = this[kLength];
return {
data: { handle, type, length },
deserializeInfo: 'internal/blob:ClonedBlob',
deserializeInfo: 'internal/blob:CloneableBlob',
Comment thread
H4ad marked this conversation as resolved.
Outdated
};
}

Expand Down Expand Up @@ -397,25 +397,27 @@ class Blob {
}
}

function ClonedBlob() {
return ReflectConstruct(function() {
class CloneableBlob extends Blob {
static {
Comment thread
anonrig marked this conversation as resolved.
Outdated
markTransferMode(this, true, false);
Comment thread
H4ad marked this conversation as resolved.
Outdated
}, [], Blob);
this[kDeserialize] = () => {};
}
}
ClonedBlob.prototype[kDeserialize] = () => {};

function TransferrableBlob(handle, length, type = '') {
CloneableBlob.prototype.constructor = Blob;

function TransferableBlob(handle, length, type = '') {
markTransferMode(this, true, false);
this[kHandle] = handle;
this[kType] = type;
this[kLength] = length;
}

ObjectSetPrototypeOf(TransferrableBlob.prototype, Blob.prototype);
ObjectSetPrototypeOf(TransferrableBlob, Blob);
ObjectSetPrototypeOf(TransferableBlob.prototype, Blob.prototype);
ObjectSetPrototypeOf(TransferableBlob, Blob);

function createBlob(handle, length, type = '') {
const transferredBlob = new TransferrableBlob(handle, length, type);
const transferredBlob = new TransferableBlob(handle, length, type);

// Fix issues like: https://github.com/nodejs/node/pull/49730#discussion_r1331720053
transferredBlob.constructor = Blob;
Expand Down Expand Up @@ -489,7 +491,7 @@ function createBlobFromFilePath(path, options) {

module.exports = {
Blob,
ClonedBlob,
CloneableBlob,
createBlob,
createBlobFromFilePath,
isBlob,
Expand Down
10 changes: 10 additions & 0 deletions test/parallel/test-blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,3 +480,13 @@ assert.throws(() => new Blob({}), {
assert.ok(blob.slice(0, 1).constructor === Blob);
assert.ok(blob.slice(0, 1) instanceof Blob);
}

(async () => {
const blob = new Blob(['hello']);

assert.ok(structuredClone(blob).constructor === Blob);
assert.ok(structuredClone(blob) instanceof Blob);
assert.ok(structuredClone(blob).size === blob.size);
assert.ok(structuredClone(blob).size === blob.size);
assert.ok((await structuredClone(blob).text()) === (await blob.text()));
})().then(common.mustCall());