Skip to content

esm: jsdoc for modules code #49523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 15 commits into from
Sep 19, 2023
Merged

esm: jsdoc for modules code #49523

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
921c63c
module, esm: jsdoc for modules files
GeoffreyBooth Sep 6, 2023
b47083e
cjs/loader.js
GeoffreyBooth Sep 8, 2023
1f2ecf2
doc: `esm/fetchModule` (and `DNS.lookup`)
JakobJingleheimer Sep 10, 2023
0cf7ac4
doc: esm/Loader
JakobJingleheimer Sep 10, 2023
6a14a29
create_dynamic_module.js
GeoffreyBooth Sep 12, 2023
47aac83
handle_process_exit.js
GeoffreyBooth Sep 12, 2023
b2272ec
esm/resolve.js, esm/package_config.js
GeoffreyBooth Sep 13, 2023
28e75ca
esm/translators.js
GeoffreyBooth Sep 14, 2023
d1222d4
esm/utils.js
GeoffreyBooth Sep 14, 2023
9b3f8cc
esm/worker.js
GeoffreyBooth Sep 14, 2023
6621451
Update lib/internal/modules/esm/loader.js
GeoffreyBooth Sep 14, 2023
5e158dd
Apply suggestions from code review
GeoffreyBooth Sep 14, 2023
21833b1
fixup! module, esm: jsdoc for modules files
GeoffreyBooth Sep 17, 2023
2b22e30
Update lib/internal/modules/helpers.js
GeoffreyBooth Sep 18, 2023
5175542
Review notes
GeoffreyBooth Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@GeoffreyBooth @aduh95
GeoffreyBooth and aduh95 committed Sep 18, 2023
commit 5e158dd3de706b283cc10abc65ba8d8c0b2cdb36
8 changes: 4 additions & 4 deletions lib/internal/modules/esm/fetch_module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const cacheForGET = new SafeMap();
/** @type {import('https').Agent} The Cached HTTP Agent for **secure** HTTP requests. */
let HTTPSAgent;
/**
* Make a **secure** HTTP GET request (handling agent setup if needed, caching the agent to avoid
* Make a HTTPs GET request (handling agent setup if needed, caching the agent to avoid
* redudant instantiations).
* @param {Parameters<import('https').get>[0]} input - The URI to fetch.
* @param {Parameters<import('https').get>[1]} options - See https.get() options.
Expand All @@ -66,10 +66,10 @@ function HTTPSGet(input, options) {
/** @type {import('https').Agent} The Cached HTTP Agent for **insecure** HTTP requests. */
let HTTPAgent;
/**
* Make a **insecure** HTTP GET request (handling agent setup if needed, caching the agent to avoid
* Make a HTTP GET request (handling agent setup if needed, caching the agent to avoid
* redudant instantiations).
* @param {Parameters<import('https').get>[0]} input - The URI to fetch.
* @param {Parameters<import('https').get>[1]} options - See http.get() options.
* @param {Parameters<import('http').get>[0]} input - The URI to fetch.
* @param {Parameters<import('http').get>[1]} options - See http.get() options.
*/
function HTTPGet(input, options) {
const http = require('http'); // [1]
Expand Down