Skip to content

buffer: refactor to remove some duplicated code in fromObject. #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
entertainyou wants to merge 8 commits into from
Closed

buffer: refactor to remove some duplicated code in fromObject. #4948

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88f2a9f
buffer: refactor to remove some duplicated code in fromObject.
entertainyou Jan 29, 2016
cdaa4ea
fixup! buffer: refactor to remove some duplicated code in fromObject.
entertainyou Jan 31, 2016
c5a886b
fixup! buffer: refactor to remove some duplicated code in fromObject.
entertainyou Feb 1, 2016
e97323d
fixup! buffer: refactor to remove some duplicated code in fromObject.
entertainyou Feb 1, 2016
980f208
fixup! fixup! buffer: refactor to remove some duplicated code in from…
entertainyou Feb 1, 2016
ab15735
fixup! fixup! fixup! buffer: refactor to remove some duplicated code …
entertainyou Feb 1, 2016
e16e88b
fixup! fixup! fixup! fixup! buffer: refactor to remove some duplicate…
entertainyou Feb 1, 2016
b274fe1
fixup! fixup! fixup! fixup! fixup! buffer: refactor to remove some du…
entertainyou Feb 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! buffer: refactor to remove some duplicated code in from… 
…Object.
  • Loading branch information
@entertainyou
entertainyou committed Feb 1, 2016
commit 980f20800baec9033385e1c89a8f332146eb4000
1 change: 0 additions & 1 deletion lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ function fromObject(obj) {
throw new TypeError('Must start with number, buffer, array or string');
}


if (obj instanceof ArrayBuffer) {
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Feb 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this check first, we can skip the isArray check and let the if block below this, take care of the creation.

Copy link
Copy Markdown
Contributor Author

@entertainyou entertainyou Feb 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, @thefourtheye .

return binding.createFromArrayBuffer(obj);
}
Expand Down