Skip to content

Fix JS Stream Socket finishShutdown crash #49400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pimterry wants to merge 2 commits into from
Closed

Fix JS Stream Socket finishShutdown crash #49400

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2050b6f
net: fix crash due to simultaneous close/shutdown on JS Stream Sockets
pimterry Aug 24, 2023
fb9611b
net: use asserts in JS Socket Stream to catch races in future
pimterry Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
net: use asserts in JS Socket Stream to catch races in future
  • Loading branch information
@pimterry
pimterry committed Aug 29, 2023
commit fb9611bd5d2940ac0ab2c835a4c10d07ebd7b99e
3 changes: 3 additions & 0 deletions lib/internal/js_stream_socket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ class JSStreamSocket extends Socket {
}

const handle = this._handle;
assert(handle !== null);

process.nextTick(() => {
// Ensure that write is dispatched asynchronously.
Expand Down Expand Up @@ -181,6 +182,8 @@ class JSStreamSocket extends Socket {
}

const handle = this._handle;
assert(handle !== null);

const self = this;

let pending = bufs.length;
Expand Down