Skip to content

stream: improve WebStreams creation performance #49089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 9 commits into from
Aug 13, 2023
Merged

stream: improve WebStreams creation performance #49089

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
470c7a1
stream: improve WebStreams performance
rluvaton Aug 9, 2023
2b4ef06
stream: format
rluvaton Aug 9, 2023
3276266
stream: wip
rluvaton Aug 10, 2023
7e021fd
stream: fix test failures
rluvaton Aug 10, 2023
ede6c54
stream: cleanup
rluvaton Aug 10, 2023
fe25995
stream: fix tests
rluvaton Aug 10, 2023
54e8215
stream: improve perf
rluvaton Aug 10, 2023
5c53418
stream: remove fn
rluvaton Aug 10, 2023
e5a3f9e
stream: improve ReadableStreamBYOBRequest
rluvaton Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stream: cleanup
  • Loading branch information
@rluvaton
rluvaton committed Aug 10, 2023
commit ede6c54f5789c43d6001870923acf8d3b6e6cee8
8 changes: 2 additions & 6 deletions lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,6 +1019,7 @@ ObjectDefineProperties(ReadableStreamBYOBReader.prototype, {

class ReadableStreamDefaultController {
[kType] = 'ReadableStreamDefaultController';
[kState] = {};

constructor(skipThrowSymbol) {
if (skipThrowSymbol !== kSkipThrow) {
Expand Down Expand Up @@ -1080,12 +1081,7 @@ ObjectDefineProperties(ReadableStreamDefaultController.prototype, {
});

function createReadableStreamDefaultController() {
const controller = new ReadableStreamDefaultController(kSkipThrow);

controller[kType] = 'ReadableStreamDefaultController';
controller[kState] = {};

return controller;
return new ReadableStreamDefaultController(kSkipThrow);
}

class ReadableByteStreamController {
Expand Down
4 changes: 1 addition & 3 deletions lib/internal/webstreams/transformstream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,7 @@ ObjectDefineProperties(TransformStreamDefaultController.prototype, {
});

function createTransformStreamDefaultController() {
const controller = new TransformStreamDefaultController(kSkipThrow);
controller[kType] = 'TransformStreamDefaultController';
return controller;
return new TransformStreamDefaultController(kSkipThrow);
}

const isTransformStream =
Expand Down
4 changes: 1 addition & 3 deletions lib/internal/webstreams/writablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,7 @@ ObjectDefineProperties(WritableStreamDefaultController.prototype, {
});

function createWritableStreamDefaultController() {
const controller = new WritableStreamDefaultController(kSkipThrow);
controller[kType] = 'WritableStreamDefaultController';
return controller;
return new WritableStreamDefaultController(kSkipThrow);
}

const isWritableStream =
Expand Down