Skip to content

[v20.x] build, deps, test, tools: avoid excessive LTO, debug information #49064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rockdrilla wants to merge 3 commits into from
Closed

[v20.x] build, deps, test, tools: avoid excessive LTO, debug information #49064

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2230927
build, deps, test: avoid excessive LTO
rockdrilla Sep 18, 2023
dc4cbc8
tools: remove non-working condition
rockdrilla Sep 18, 2023
26269b0
build, tools: avoid extra debug information
rockdrilla Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build, tools: avoid extra debug information 
Don't build intermediate executables with debug information in order
to save some disk space during build.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
  • Loading branch information
@rockdrilla
rockdrilla committed Sep 18, 2023
commit 26269b0bf6d9ca094af584d012556154cbac2fdf
24 changes: 24 additions & 0 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,6 +993,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
}, # fuzz_env
{
Expand Down Expand Up @@ -1101,6 +1105,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
}, # cctest

Expand Down Expand Up @@ -1158,6 +1166,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
}, # embedtest

Expand All @@ -1180,6 +1192,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
]
}, # overlapped-checker
{
Expand Down Expand Up @@ -1217,6 +1233,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
]
},
{
Expand Down Expand Up @@ -1280,6 +1300,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
}, # node_mksnapshot
], # end targets
Expand Down
20 changes: 20 additions & 0 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,6 +1502,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
'defines!': [
'BUILDING_V8_SHARED=1',
Expand Down Expand Up @@ -1544,6 +1548,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
}, # mksnapshot
{
Expand All @@ -1561,6 +1569,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
'defines!': [
'_HAS_EXCEPTIONS=0',
Expand Down Expand Up @@ -1599,6 +1611,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
'dependencies': [
'torque_base',
Expand Down Expand Up @@ -1635,6 +1651,10 @@
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],
# Avoid extra debug information
['v8_enable_handle_zapping==0', {
'ldflags': [ '-s' ],
}],
],
'sources': [
"<(V8_ROOT)/src/regexp/gen-regexp-special-case.cc",
Expand Down