Skip to content

esm: unflag import.meta.resolve #49028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 8 commits into from
Aug 13, 2023
Merged

esm: unflag import.meta.resolve #49028

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7797444
esm: unflag import.meta.resolve
guybedford Aug 5, 2023
719c418
update pr url
guybedford Aug 5, 2023
1c5c2d8
replaceme
guybedford Aug 5, 2023
f865a1d
docs changes
guybedford Aug 5, 2023
69796fd
pr feedback
guybedford Aug 6, 2023
09f2bef
Update lib/internal/modules/esm/initialize_import_meta.js
guybedford Aug 7, 2023
c94c64e
fixup default arg
guybedford Aug 7, 2023
a0ab43d
add stability, fix typos
GeoffreyBooth Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pr feedback
  • Loading branch information
@guybedford @GeoffreyBooth
guybedford authored and GeoffreyBooth committed Aug 13, 2023
commit 69796fd8e387976c2e5ff3d7eca7dacc0e8164a4
7 changes: 5 additions & 2 deletions lib/internal/modules/esm/initialize_import_meta.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ const experimentalImportMetaResolve = getOptionValue('--experimental-import-meta
* @param {string} defaultParentURL The default base to use for resolution
* @param {typeof import('./loader.js').ModuleLoader} loader Reference to the current module loader
* @param {bool} allowParentURL Whether to permit parentURL second argument for contextual resolution
* @returns {(specifier: string, parentURL?: string) => string} Function to assign to import.meta.resolve
* @returns {(specifier: string) => string} Function to assign to import.meta.resolve
*/
function createImportMetaResolve(defaultParentURL, loader, allowParentURL) {
return function resolve(specifier) {
Comment thread
guybedford marked this conversation as resolved.
Outdated
let url;
const parentURL = allowParentURL ? arguments[1] ?? defaultParentURL : defaultParentURL;

const parentURL = allowParentURL ?
arguments[1] ?? defaultParentURL :
defaultParentURL;

try {
({ url } = loader.resolveSync(specifier, parentURL));
Expand Down
1 change: 0 additions & 1 deletion test/es-module/test-esm-loader-hooks.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ describe('Loader hooks', { concurrency: true }, () => {
it('should be fine to call `process.exit` from a custom sync hook', async () => {
const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
'--no-warnings',
'--experimental-import-meta-resolve',
'--experimental-loader',
'data:text/javascript,export function resolve(a,b,next){if(a==="exit:")process.exit(42);return next(a,b)}',
'--input-type=module',
Expand Down