Skip to content

benchmark: add benchmarks for the test_runner #48931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 9 commits into from
Jul 29, 2023
Merged

benchmark: add benchmarks for the test_runner #48931

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8700926
benchmark: add benchmarks for the test_runner
rluvaton Jul 26, 2023
4781ca7
remove todo
rluvaton Jul 26, 2023
d9e9b1c
remove 1K suites due to OOM in conjunction with 1K tests per suite
rluvaton Jul 26, 2023
a67b01d
rename files
rluvaton Jul 26, 2023
82e20f7
sync and async tests
rluvaton Jul 26, 2023
1308c10
sync and async tests
rluvaton Jul 26, 2023
929e0d2
add concurrency options
rluvaton Jul 26, 2023
dbb1380
trigger GitHub Actions CI
rluvaton Jul 28, 2023
994e575
avoid v8 optimization
rluvaton Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
benchmark: add benchmarks for the test_runner
  • Loading branch information
@rluvaton
rluvaton committed Jul 26, 2023
commit 8700926fcd837386284c354c76b677b176ca8464
8 changes: 8 additions & 0 deletions benchmark/fixtures/empty-test-reporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const { PassThrough } = require('node:stream');

module.exports = new PassThrough({
objectMode: true,
transform(chunk, encoding, callback) {
callback(null)
},
});
28 changes: 28 additions & 0 deletions benchmark/test_runner/plain-tests-as-fast-as-can.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
'use strict';
const common = require('../common');
const { it } = require('node:test');

const bench = common.createBenchmark(main, {
n: [100, 1000, 1e4],
}, {
// We don't want to test the reporter here
flags: ['--test-reporter=./benchmark/fixtures/empty-test-reporter.js'],
});

async function run(n) {
const promises = new Array(n);
for (let i = 0; i < n; i++) {
promises[i] = it(`${i}`, () => {
});
}

// TODO: Should I use finished on the reporter or this?
await Promise.all(promises);
Copy link
Copy Markdown
Member Author

@rluvaton rluvaton Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use finished on the reporter or this?

}

function main({ n }) {
bench.start();
run(n).then(() => {
bench.end(n);
});
}
25 changes: 25 additions & 0 deletions benchmark/test_runner/plain-tests-waiting-for-each-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'use strict';
const common = require('../common');
const { it } = require('node:test');


const bench = common.createBenchmark(main, {
n: [100, 1000, 1e4],
}, {
// We don't want to test the reporter here
flags: ['--test-reporter=./benchmark/fixtures/empty-test-reporter.js'],
});

async function run(n) {
for (let i = 0; i < n; i++) {
await it(`${i}`, () => {
});
}
}

function main({ n }) {
bench.start();
run(n).then(() => {
bench.end(n);
});
}
37 changes: 37 additions & 0 deletions benchmark/test_runner/suite-tests-as-fast-as-can.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
'use strict';
const common = require('../common');
const { finished } = require('node:stream/promises');

const reporter = require('../fixtures/empty-test-reporter');

const { describe, it } = require('node:test');

const bench = common.createBenchmark(main, {
numberOfSuites: [10, 100, 1000],
testsPerSuite: [10, 100, 1000],
}, {
// We don't want to test the reporter here
flags: ['--test-reporter=./benchmark/fixtures/empty-test-reporter.js'],
});

async function run(numberOfSuites, testsPerSuite) {
for (let i = 0; i < numberOfSuites; i++) {
describe(`${i}`, () => {
for (let j = 0; j < testsPerSuite; j++) {
it(`${j}`, () => {
});
}
});
}

await finished(reporter);

return numberOfSuites * testsPerSuite;
}

function main({ numberOfSuites, testsPerSuite }) {
bench.start();
run(numberOfSuites, testsPerSuite).then((ops) => {
bench.end(ops);
});
}