Skip to content

inspector: open add SymbolDispose #48765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jul 16, 2023
Merged

inspector: open add SymbolDispose #48765

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9e291f
inspector: open add `SymbolDispose`
atlowChemi Jul 14, 2023
1bdf897
fix test
atlowChemi Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
@atlowChemi
atlowChemi committed Jul 15, 2023
commit 1bdf897025cba5bb4a63e666a75dca49de167562
6 changes: 3 additions & 3 deletions test/parallel/test-inspector-open-dispose.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import * as common from '../common/index.mjs';
import * as inspector from 'node:inspector';
import assert from 'node:assert';
import net from 'node:net';
import url from 'node:url';
import { fork } from 'node:child_process';

common.skipIfInspectorDisabled();
if (process.env.BE_CHILD) {
beChild();
await beChild();
} else {
let firstPort;

Expand Down Expand Up @@ -60,7 +59,8 @@ function ping(port, callback) {
}
}

function beChild() {
async function beChild() {
const inspector = await import('node:inspector');
let inspectorDisposer;
process.send({ cmd: 'started' });

Expand Down