Skip to content

deps: update V8 to 11.6 #48710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 19 commits into from
Closed

deps: update V8 to 11.6 #48710

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
80a16f3
deps: update V8 to 11.6.189.15
targos Jul 31, 2023
464982a
build: reset embedder string to "-node.0"
targos Jul 31, 2023
e588e11
src: update NODE_MODULE_VERSION to 118
targos Jul 9, 2023
78f09ae
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
918c77d
deps: silence irrelevant V8 warning
targos Jun 21, 2022
dff4e7c
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
cdebfb6
deps: avoid compilation error with ASan
targos Jul 31, 2023
f49535f
deps: V8: cherry-pick 1a782f6543ae
kvakil Jun 22, 2023
8e31196
deps: V8: cherry-pick c1a54d5ffcd1
joyeecheung Jul 18, 2023
393c0b5
deps: V8: cherry-pick 9f4b7699f68e
joyeecheung Jul 19, 2023
70639b7
deps: V8: cherry-pick 93275031284c
joyeecheung Jun 26, 2023
a16e7bd
tools: update V8 gypfiles for 11.4
targos Mar 31, 2023
6513a2c
tools: add new V8 headers to distribution
targos Mar 31, 2023
28312e4
lib: update usage of always on Atomics API
targos Apr 16, 2023
e717980
test: adapt debugger tests to V8 11.4
pfaffe Mar 17, 2023
bd4f22b
test: update flag to disable SharedArrayBuffer
targos Apr 20, 2023
dc8f280
tools: update V8 gypfiles for 11.5
targos Apr 30, 2023
46edced
test: adapt test-fs-write to V8 internal changes
targos May 6, 2023
3baa85b
tools: update V8 gypfiles for 11.6
targos Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: adapt debugger tests to V8 11.4 
Accept a new `step` break message.
  • Loading branch information
@pfaffe @targos
pfaffe authored and targos committed Jul 31, 2023
commit e717980e68eed81c88957955e01a047a49fb2c5a
6 changes: 3 additions & 3 deletions test/common/debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const spawn = require('child_process').spawn;

const BREAK_MESSAGE = new RegExp('(?:' + [
'assert', 'break', 'break on start', 'debugCommand',
'exception', 'other', 'promiseRejection',
'exception', 'other', 'promiseRejection', 'step',
].join('|') + ') in', 'i');

let TIMEOUT = common.platformTimeout(5000);
Expand Down Expand Up @@ -121,13 +121,13 @@ function startCLI(args, flags = [], spawnOpts = {}) {
get breakInfo() {
const output = this.output;
const breakMatch =
output.match(/break (?:on start )?in ([^\n]+):(\d+)\n/i);
output.match(/(step |break (?:on start )?)in ([^\n]+):(\d+)\n/i);

if (breakMatch === null) {
throw new Error(
`Could not find breakpoint info in ${JSON.stringify(output)}`);
}
return { filename: breakMatch[1], line: +breakMatch[2] };
return { filename: breakMatch[2], line: +breakMatch[3] };
},

ctrlC() {
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-debugger-break.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const cli = startCLI(['--port=0', script]);

await cli.stepCommand('n');
assert.ok(
cli.output.includes(`break in ${script}:2`),
cli.output.includes(`step in ${script}:2`),
'pauses in next line of the script');
assert.match(
cli.output,
Expand All @@ -36,7 +36,7 @@ const cli = startCLI(['--port=0', script]);

await cli.stepCommand('next');
assert.ok(
cli.output.includes(`break in ${script}:3`),
cli.output.includes(`step in ${script}:3`),
'pauses in next line of the script');
assert.match(
cli.output,
Expand Down Expand Up @@ -89,7 +89,7 @@ const cli = startCLI(['--port=0', script]);
await cli.stepCommand('');
assert.match(
cli.output,
/break in node:timers/,
/step in node:timers/,
'entered timers.js');

await cli.stepCommand('cont');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-debugger-run-after-quit-restart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const path = require('path');
.then(() => cli.stepCommand('n'))
.then(() => {
assert.ok(
cli.output.includes(`break in ${script}:2`),
cli.output.includes(`step in ${script}:2`),
'steps to the 2nd line'
);
})
Expand Down