Skip to content

test: fs.link() on same device #4859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drewfish wants to merge 1 commit into from
Closed

test: fs.link() on same device #4859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fs.link() on same device 
If `NODE_TEST_DIR` is set to a device different than the location of the
test files (where this repo is checked out), then the
parallel/test-fs-link.js test will fail with `EXDEV: cross-device link
not permitted`. The code works fine (and is in fact throwing an error as
desired) but the test fails.

This commit first copies the "source" file to the same directory as the
"destination" (where the hardlink will be created).
  • Loading branch information
@drewfish
drewfish committed Jan 25, 2016
commit 742663ff44b991b6f0f665dd005ed927de51d516
7 changes: 5 additions & 2 deletions test/parallel/test-fs-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,16 @@ common.refreshTmpDir();

// test creating and reading hard link
const srcPath = path.join(common.fixturesDir, 'cycles', 'root.js');
const tmpSrcPath = path.join(common.tmpDir, 'root.js');
const dstPath = path.join(common.tmpDir, 'link1.js');
const srcContent = fs.readFileSync(srcPath, 'utf8');

const callback = function(err) {
if (err) throw err;
const srcContent = fs.readFileSync(srcPath, 'utf8');
const dstContent = fs.readFileSync(dstPath, 'utf8');
assert.strictEqual(srcContent, dstContent);
};

fs.link(srcPath, dstPath, common.mustCall(callback));
// copy to same directory to avoid cross-filesystem issues
fs.writeFileSync(tmpSrcPath, srcContent, 'utf8');
fs.link(tmpSrcPath, dstPath, common.mustCall(callback));