Skip to content

src: fix logically dead code reported by Coverity #48589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 4, 2023
Merged

src: fix logically dead code reported by Coverity #48589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: fix logically dead code reported by Coverity 
Value of the `nwrite` variable will always be less than 0 when it
reaches the `switch` statement because of the previous check, which
causes `case 0` to never be executed, change the check to allow 0 or
less.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva committed Jun 28, 2023
commit d765ac44b1d1747f28e595f8c8df1c39160e4488
2 changes: 1 addition & 1 deletion src/quic/session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ uint64_t Session::SendDatagram(Store&& data) {
1,
uv_hrtime());

if (nwrite < 0) {
if (nwrite < 1) {
// Nothing was written to the packet.
switch (nwrite) {
case 0: {
Expand Down