Skip to content

quic: next iteration #48244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 8 commits into from
Closed

quic: next iteration #48244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
74eb03d
quic: add backpressure notification to dataqueue
jasnell May 29, 2023
8f3b1e4
quic: add streams implementation
jasnell May 28, 2023
50cf6c5
quic: address review comments
jasnell May 29, 2023
43acc5f
quic: address review comments
jasnell May 29, 2023
d8fe4e7
quic: address review comments
jasnell May 29, 2023
fc7da04
quic: fix cpp formatting
jasnell May 29, 2023
7ca1bfb
quic: fixup mac build issue
jasnell Jun 3, 2023
81a31c6
quic: address review comments
jasnell Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
quic: address review comments
  • Loading branch information
@jasnell
jasnell committed Dec 9, 2023
commit 81a31c6996baf997da4a5387f2e004d69f299036
4 changes: 2 additions & 2 deletions src/dataqueue/queue.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ class DataQueueImpl final : public DataQueue,

void NotifyBackpressure(size_t amount) {
if (idempotent_) return;
for (auto listener : backpressure_listeners_) listener->EntryRead(amount);
for (auto& listener : backpressure_listeners_) listener->EntryRead(amount);
}

bool HasBackpressureListeners() const {
bool HasBackpressureListeners() const noexcept {
return !backpressure_listeners_.empty();
}

Expand Down
2 changes: 1 addition & 1 deletion src/quic/streams.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ BaseObjectPtr<Blob::Reader> Stream::get_reader() {

void Stream::set_final_size(uint64_t final_size) {
DCHECK_IMPLIES(state_->fin_received == 1,
final_size <= stats_.Get<&Stats::final_size>());
final_size <= STAT_GET(Stats, final_size));
state_->fin_received = 1;
STAT_SET(Stats, final_size, final_size);
}
Expand Down